Attending: timmywil, DaveMethvin, m_gol, gibson042

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.12.4%2F2.2.4
• https://github.com/jquery/jquery/issues/3065
  • Seems high priority for WordPress, discussion in IRC
  • http://irc.jquery.org/%23jquery-dev/default_%23jquery-dev_20160429.log.html#t16:02:40
  • Does https://github.com/jquery/jquery/pull/3057 fix?
    • Yes, but not the way we want. Timmy is 5min from a PR.
• https://github.com/jquery/jquery/issues/3043
  • Related to 3065? No
  • There are 2 issues. The IE8 path wasn’t accounting for disconnected nodes and modern browsers were failing the support test when certain global table CSS was on the page.

link 3.0 Upgrade Guide

• https://github.com/jquery/jquery.com/blob/master/pages/upgrade-guide/3.0.md
• https://jquery.com/upgrade-guide/3.0/
  • Should be up to date with all non-trivial changes now
• Potential additions?s
  • event fixHooks changes that we decide to land
  • jQuery.when changes from https://github.com/jquery/jquery/pull/3059

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery/pull/2860
  • How far should we go? Let's land at least the first part ASAP
• https://github.com/jquery/jquery/issues/3029 $.when().done() regression
  • gibson042

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
  • Switched to strict mode, following core
• https://github.com/jquery/jquery-migrate/issues/173
  • Needs a review, otherwise ready
• https://github.com/jquery/jquery-migrate/issues/102
  • gibson042 can you describe a few cases here?
  • Depending on which fixHook changes land we'll need changes there, jbedard proposed a Migrate fill
  • https://github.com/jquery/jquery/pull/2860#issuecomment-215652293

Attending: markelog, m_gol, DaveMethvin, gibson042

link Upgrade Guide

• Moved and rearranged content by subsystem and impact
• https://github.com/jquery/jquery.com/blob/master/pages/upgrade-guide/3.0.md
• https://jquery.com/upgrade-guide/3.0/
• Still need input and writeup on show/hide changes and remediation (gibson)
• Add note about strict mode if we decide that (dave)

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues/3041
  • m_gol will revert the hacky workaround
• https://github.com/jquery/jquery/issues/3043
  • .contains() check?

link 3.0

• Remove support for Yandex.Browser?
  • Browserstack isn't updating (2014 version)
  • May not be worth nagging them to update
  • Decided to remove support for 3.0
  • Markelog to update support matrix & remove from Swarm
• Switch to strict mode?
  • Yes
  • Bug and PR already exists for the Uglify bug we encountered
  • Need to strip out excess "use strict" as part of the fn wrappers
• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery/issues/3064 Revert easing param removal
  • Markelog
• https://github.com/jquery/jquery/issues/3056
  • Dave
  • Nvm, closed
• https://github.com/jquery/jquery/issues/3029 $.when().done() regression
  • gibson042

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• gibson042 to look at show/hide in Migrate
• Also should switch to strict mode if core does?

Attending: timmywil, markelog, m_gol, DaveMethvin, gibson042

link Upgrade Guide

• Still need input and writeup on show/hide changes and remediation (gibson)
• https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#
• gibson042 almost done with the writeup

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues/3041 has IE 11 fixed the bug they promised not to fix?

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0

link JSHint, JSCS, ESLint

• Should we switch to ESLint completely?

link Issues needing review

• https://github.com/jquery/jquery/issues/2824 # in selectors
  • No revert
  • “be more careful with code changes that may introduce exceptions on invalid input, during code review, but not have a policy to test for invalid input”
  • “it doesn't mean we're not going to introduce exceptions, but we can make sure people have warning.” Moving an exception to major version may be appropriate.
• https://github.com/jquery/jquery/issues/3060 Remove default Deferred callback context
  • Yes

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
  • gibson042 to look at show/hide in Migrate

Attending: m_gol, gibson042, markelog, dmethvin, timmywil

link Upgrade Guide

• Still need input and writeup on show/hide changes and remediation (gibson)
• https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#
• gibson042 almost done with the writeup

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• Down to 2!
• Blocker https://github.com/jquery/jquery/issues/3029 $.when(dfd).done() args
• Blocker https://github.com/jquery/jquery/issues/3010 dave to pester gdsmith but let's not call it a blocker

link PRs

• https://github.com/jquery/jquery/pull/3037 Toggle detached elements
  • LGTM

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery-migrate/issues/118
  • Dave will grab
• gibson042 to look at show/hide in Migrate

Attending: timmywil, m_gol, gibson042, markelog

link Upgrade Guide

• Still need input and writeup on show/hide changes and remediation (gibson)
• https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• Down to 4!
• New blocker https://github.com/jquery/jquery/issues/3029 $.when(dfd).done() args

link 1.12.3/2.2.3

• Fix https://github.com/jquery/jquery/issues/3035 context for .load

link PRs

• https://github.com/jquery/jquery/pull/3037 Toggle detached elements
  • LGTM

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• 7 left. gibson to help with show/hide.

Attending: timmywil, markelog, DaveMethvin, gibson042

link Upgrade Guide

• Still need input and writeup on show/hide changes and remediation (gibson)
• https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• Need to finish upgrade guide (at least first draft) and land existing PRs before release.
• https://github.com/jquery/jquery/issues/2863 Blocker

link Go ahead and release 1.12.3

link PRs

• https://github.com/jquery/jquery/pull/2891 non-ready Deferred option
  • Side-effect is ready execution after ready event is fired is no longer sync
• https://github.com/jquery/jquery/pull/3022 set base href in parseHTML
  • Needs review
• https://github.com/jquery/jquery/pull/3021 support singleton
  • LGTM
• https://github.com/jquery/jquery/pull/3014 support comments
  • LGTM, pending gibson’s comments
• https://github.com/jquery/jquery/pull/3007 Serialize: set empty string on null
  • LGTM

link Migrate

• Dave to work on some open tickets this week
• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• Help needed, especially on show/hide (gibson to help)

Attending: timmywil, DaveMethvin, m_gol, gibson042, markelog

link 1.12.2/2.2.2

• Shipped!

link Upgrade Guide

• Reviewed, thanks!
• Deprecations added at the end
• Still need input and writeup on show/hide changes and remediation (gibson)
• https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• Strange results with requestAnimationFrame? See discussion between markelog and dmethvin in upgrade guide comments
  • Seems inconsistent/dependent on focus. Will test more, but plan on keeping code as-is.
• Remaining issues assigned. Non-pertinent issues pushed.
• Plan on RC next Monday.

link Issues needing review

• https://github.com/jquery/jquery/issues/3000 Deferred.resolve(1)
  • Will not block 3.0

link Migrate

• Dave to work on some open tickets this week
• Help needed, especially on show/hide (gibson to help)

link 1.12.2/2.2.2 XSS-related difference

• https://github.com/jquery/jquery/issues/2432#issuecomment-199098662
• Opened https://github.com/jquery/jquery/issues/3011

Attending: timmywil, DaveMethvin, markelog, m_gol, all3fox, gibson042

link 1.12.2/2.2.2

• Merged https://github.com/jquery/jquery/pull/2985
• One more issue https://github.com/jquery/jquery/issues/2978 .val

link PRs

• https://github.com/jquery/jquery/pull/2996 detached.show()
  • Must make decision for 3.0
  • Keep current behavior, update later if needed
  • Poll (excluding gibson042 and markelog)
    • jQuery("<div/>").hide().css("display"): 2.5–0 "none"
    • jQuery("<div/>").show().css("display"): 1.5–0 ""

link Upgrade Guide

• Draft, unfinished and not ready for review
  • https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#

link BrowserStack IE 6 clients

• BrowserStack keeps 2 constantly online IE 6 clients just for us. They may turn them off after 1.12.2.

link jQuery Periodic runs for 1.x/2.x - still needed?

• Stop after 1.12.2/2.2.2

link Migrate

• Migrate needs more help for 3.0
• Remaining 3.0 issues
  • https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0

Attending: timmywil, m_gol, DaveMethvin, gibson042

link Fixing the 3.0.0 milestone

• A non-trivial amount of issues backported to 1.12/2.2 had a 3.0.0 milestone
• m_gol looked at all 3.0.0 issues and changed the relevant ones, adding a comment: “This has been backported to 1.12.0 & 2.2.0 so I changed the milestone (it used to say 3.0.0).”
• What should we do about those tickets? They weren’t mentioned in the 1.12.0/2.2.0 blog post, they won’t be mentioned in the 3.0.0 one.
  • Timmy can add them to the blog post if we compile a list

link Changelogs

• Create changelog archive page for core?
  • 3.0+ only
• Dave to start an upgrade guide on jquery.com

link PRs

• https://github.com/jquery/jquery/pull/2126 async manip script load
• https://github.com/jquery/jquery/pull/2949 code/support comments cleanup
  • LGTM

link Migrate

• Migrate needs more help for 3.0
• Remaining 3.0 issues
  • https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0

Attending: timmywil, DaveMethvin, m_gol, markelog, gibson042

link Deprecate <1.11 npm versions

• Syntax: https://docs.npmjs.com/cli/deprecate
• "Versions of the jquery npm package older than 1.9.0 are patched versions that don't work in web browsers. Please upgrade to >=1.11.0."
• Look into which of the latest versions do work on web browsers
• It should be: old Node-based <=1.8, new ours >=1.11 but 1.9.1 has been published 2 months after 1.11.1, what’s up about that?
  • I recall publishing an older version because it was completely absent.

link Issues needing review

• https://github.com/jquery/jquery/issues/2941 remove document.implementation usage
  • Remove only in 1.12.2/2.2.2 for now
• https://github.com/jquery/jquery/issues/2945 hardcode path to sizzle
  • g2g

link PRs

• https://github.com/jquery/jquery/pull/2126 async manip script load
  • tabled for next week

link Migrate

• Migrate needs more help for 3.0
• Remaining 3.0 issues
  • https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0