Attending: timmywil, mgol, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/4544
  • Merged!
• UI: https://github.com/jquery/jquery-ui/pull/1901
  • reviewed
• https://github.com/jquery/jquery/issues/4548
  • Build error
  • https://github.com/jquery/jquery/pull/4549
    • LGTM
• https://github.com/jquery/jquery/issues/4546
  • Incorrect JSDOM setup instructions
  • PR: https://github.com/jquery/jquery-dist/pull/5
    • LGTM
• Discuss https://github.com/jquery/jquery/issues/4382
• Discuss the one-var ESLint rule https://eslint.org/docs/rules/one-var
• https://github.com/jquery/jquery/pull/4550
  • Make Karma work in ES modules mode
• https://github.com/jquery/jquery/pull/4553
  • Exclude callbacks & deferred modules in the slim build as well
• https://github.com/jquery/jquery/pull/4554
  • Auto-convert sources to AMD

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
• Need to get 3.0 deprecations in the docs
  • https://github.com/jquery/api.jquery.com/issues/970

link Swarm check

• http://swarm.jquery.org/result/3357270
  • Intermittent 1 pixel diffs in iOS 11.4+

Attending: timmywil, mgol, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/4529
  • Firefox 70 + dimensions
• https://github.com/jquery/jquery/pull/4520
  • looks stale
• https://github.com/jquery/jquery/pulls
  • cool modules
• UI: https://github.com/jquery/jquery-ui/pull/1901

• reviewed

• https://github.com/jquery/jquery/pull/4510

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
• Need to get 3.0 deprecations in the docs

• https://github.com/jquery/api.jquery.com/issues/970

link Swarm check

• http://swarm.jquery.org/result/3357270

• Intermittent 1 pixel diffs in iOS 11.4+

Attending: timmywil, mgol, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/4510
• https://github.com/jquery/eslint-config-jquery/issues/15
  • ESLint config changes
  • Both rules look fine
• UI: https://github.com/jquery/jquery-ui/pull/1901
  • A review from someone from Core would be nice (from the point of whether new code is equivalent to the old one)

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
• Need to get 3.0 deprecations in the docs
  • https://github.com/jquery/api.jquery.com/issues/970

link Swarm check

• http://swarm.jquery.org/result/3357270
  • Intermittent 1 pixel diffs in iOS 11.4+

October 28, 2019 Attending: timmywil, mgol

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/4510
  • Empty attribute selectors in IE/Edge
  • Sizzle version merged but may need followups: https://github.com/jquery/sizzle/pull/461
• https://github.com/jquery/jquery/issues/4529
  • https://bugzilla.mozilla.org/show_bug.cgi?id=1590837
  • .skip for now, will revisit after more discussion
• https://github.com/jquery/eslint-config-jquery/issues/15
  • ESLint config changes
• UI: https://github.com/jquery/jquery-ui/pull/1901
  • A review from someone from Core would be nice (from the point of whether new code is equivalent to the old one)

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
  • Need to get 3.0 deprecations in the docs
• https://github.com/jquery/api.jquery.com/issues/970

link Swarm check

• http://swarm.jquery.org/result/3357270
  • Intermittent 1 pixel diffs in iOS 11.4+

Attending: timmywil, mgol, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/4524
  • Will use both ChromeHeadless & FirefoxHeadless in travis
• https://github.com/jquery/jquery/pull/4517
  • Remove jQuery.find from tests
• https://github.com/jquery/jquery/pull/4516
  • Throw on invalid post-comma selectors
  • Sizzle version: https://github.com/jquery/sizzle/pull/463
• https://github.com/jquery/jquery/pull/4512
  • Shallow doc comparison in uniqueSort
• https://github.com/jquery/jquery/pull/4511
  • http -> https
• https://github.com/jquery/jquery/pull/4510
  • Empty attribute selectors in IE/Edge
  • Sizzle version: https://github.com/jquery/sizzle/pull/461
• https://github.com/jquery/jquery/pull/4508
  • PR for 3.5
  • Issue for 4.0: https://github.com/jquery/jquery/issues/4525
• https://github.com/jquery/sizzle/pull/464
  • UI: https://github.com/jquery/jquery-ui/pull/1901
  • A review from someone from Core would be nice (from the point of whether new code is equivalent to the old one)

link Other issues

• New CLA or DCO? Discuss
• What infra do we need for Core?

link Swarm check

• http://swarm.jquery.org/result/3357270
  • Intermittent 1 pixel diffs in iOS 11.4+

Attending: timmywil, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/4496
  • Closed
• https://github.com/jquery/jquery/issues/4435
  • Check if workaround is global
  • Check if support test works when detached
  • https://github.com/jquery/jquery/pull/4510
  • https://github.com/jquery/sizzle/pull/460
• https://github.com/jquery/jquery/pull/4509
  • Selectors with leading combinators can use qsa
  • LGTM
• https://github.com/jquery/jquery/pull/4506
  • https://github.com/jquery/jquery/pull/4503
  • LGTM

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
  • Need to get 3.0 deprecations in the docs
  • https://github.com/jquery/api.jquery.com/issues/970

link Swarm check

• http://swarm.jquery.org/result/3357270
  • Intermittent 1 pixel diffs in iOS 11.4

Attending: timmywil, mgol, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/4490
  • IE/Edge returning inline style in getComputedStyle
• https://github.com/jquery/sizzle/pull/453
  • Selector: Leverage the :scope pseudo-class where possible
  • Mgol to check :has behavior & merge if it looks good
• https://github.com/jquery/sizzle/pull/459
  • Use shallow comparison for documents (Sizzle PR)
  • Merged
• https://github.com/jquery/jquery-mousewheel/issues/202
  • Can jquery-mousewheel be expired? @dmethvin
• https://github.com/jquery/jquery/issues/4463
  • https://bugzilla.mozilla.org/show_bug.cgi?id=1584752
• https://github.com/jquery/jquery/issues/4496
  • How many listeners should be there?

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
  • Need to get 3.0 deprecations in the docs
• https://github.com/jquery/api.jquery.com/issues/970
  • sizzlejs.com now redirects to the wiki!

link Swarm check

• http://swarm.jquery.org/result/3344660
  • 1 pixel diffs in iOS 11.4

Attending: timmywil, mgol, gibson042, dmethvin

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/4490
  • IE/Edge returning inline style in getComputedStyle
• https://github.com/jquery/jquery/pull/4492
  • core.js made its way into dist/
• https://github.com/jquery/sizzle/pull/453
  • Selector: Leverage the :scope pseudo-class where possible
  • Waiting for @gibson’s review
• https://github.com/jquery/sizzle/pull/459
  • Use shallow comparison for documents (Sizzle PR)
• https://github.com/jquery/jquery-mousewheel/issues/202
  • A temporary workaround for Core missing passive event support?
  • Im against magic namespaces
  • Can jquery-mousewheel be expired? @dmethvin
• https://github.com/jquery/jquery/pull/4461
  • CP’d to 3.x-stable by mgol

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
  • Need to get 3.0 deprecations in the docs
  • https://github.com/jquery/api.jquery.com/issues/970
• Sizzle home page is broken
  • https://github.com/jquery/sizzle/issues/447
  • Redirect pages that reference sizzlejs.com to wiki

link Swarm check

• http://swarm.jquery.org/result/3344660
  • 1 pixel diffs in iOS 11.4

Attending: timmywil, jbedard, mgol, gibson042

Location: https://gitter.im/jquery/meeting

link Travis build on Sizzle is green!

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/4454
  • Accepted, Gibson to try to reduce from current +43 +37 bytes
  • https://github.com/jquery/sizzle/pull/453
• https://github.com/jquery/jquery/pull/4462 Reduce setDocument
  • LGTM
• https://github.com/jquery/jquery/pull/4467
  • Ajax: Simplify jQuery.ajaxSettings.xhr
• https://github.com/jquery/jquery/pull/4466
  • Build: Remove the external directory, read from node_modules directly
• https://github.com/jquery/sizzle/pull/453
  • Selector: Leverage the :scope pseudo-class where possible
  • The backport to Sizzle so that it also lands in 3.x
• https://github.com/jquery/sizzle/pull/452
  • Restoring some optimization accidentally removed during ESLint introduction
  • Needs feedback from @gibson
• https://github.com/jquery/jquery-release/issues/99
  • PR: https://github.com/jquery/jquery-release/pull/100
  • mgol: we probably can’t use it? ✓

link Docs

• https://github.com/jquery/api.jquery.com/milestone/2
  • Mainly need to get 3.0 deprecations in the docs
• https://github.com/jquery/api.jquery.com/issues/970
  • Sizzle home page is broken
  • https://github.com/jquery/sizzle/issues/447
  • Redirect pages that reference sizzlejs.com to wiki

link Others

• Archive all repos under https://github.com/jquery-archive
  • Probably need Dave to do this.
• Move https://github.com/jquery/jquery-compat-dist into jquery-archive & archive it
  • yes

link Swarm check

• http://swarm.jquery.org/job/9206
  • Partial pixel failure on Chrome Android 8
  • 1 pixel diffs in iOS 11.4

Attending: timmywil, dmethvin, gibson042, jbedard, mgol

Location: https://gitter.im/jquery/meeting

link Sizzle failing Travis build

• https://travis-ci.org/jquery/sizzle/builds/573810898
  • Switch FF to FF headless

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/4458
  • LGTM
• https://github.com/jquery/jquery/pull/4461
  • LGTM, pending PR cleanup and CLI sig
• https://github.com/jquery/jquery/pull/4454
  • Accepted, Gibson to try to reduce from current +43 bytes
• https://github.com/jquery/jquery/pull/4462 Reduce setDocument
  • Needs reviews

link Dave giving some love to jquery UI and jquery mousewheel for 4.0

link Swarm check

• http://swarm.jquery.org/job/9206
  • Partial pixel failure on Chrome Android 8
  • 1 pixel diffs in iOS 11.4