Attending: timmywil, dmethvin, jbedard, markelog, mgol, gibson042 Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4109 is(‘:focus’) in edge
  • Sounds like checking focus is causing the input to lose focus in Edge.
• https://github.com/jquery/jquery/issues/4031 store dist output
  • Any more thoughts on the options?
• http://swarm.jquery.org/job/7504
  • CSS in iOS 7: zoom issue
  • Manip in Edge: issue with module script loading
  • Dimensions in IE9: issue with scrollbars
  • Dimensions in iOS7: issue with new SVG tests
• https://github.com/jquery/jquery/pull/4122
  • LGTM

link BrowserStack removed emulators half a year early. :(

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, gibson042, mgol, markelog Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4109 is(‘:focus’) in edge
• https://github.com/jquery/jquery/issues/4113 Safari animation flicker
  • Confirmed, possible the earlier double tick was hiding this issue
  • Seen in Mac OS Safari and Safari on iOS 11 & 10
• http://swarm.jquery.org/job/7504
  • CSS in iOS 7: zoom issue
  • Manip in Edge: issue with module script loading
  • Dimensions in IE9: issue with scrollbars
  • Dimensions in iOS7: issue with new SVG tests

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, mgol, jbedard, dmethvin Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/codeorigin.jquery.com/issues/23
  • Yes, remove
  • Manual sourcemap association
    • Chrome, DevTools, Sources Tab, open a file and right click its contents
• Can we drop special treatment of boolean attrs? https://github.com/angular/angular.js/issues/16602#issuecomment-397794145
  • Too much of a breaking change. The special treatment is there to avoid users doing things like .attr(‘checked’, false), which would actually be true, and .attr(‘checked’, true), which would not be valid. This would happen all the time and cause more problems than it solves.
  • Some options
    • limit the disabled behavior to form elements. In fact, many boolean attributes only apply to form elements.
    • Check for the existence of the attribute first
    • Only change the value for empty string, maybe don’t change the string at all. Still remove on false (note: not “false”).
  • https://github.com/jquery/jquery/issues/4114

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, jbedard, mgol, markelog Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/pull/4096 width + SVG
  • Merge
• https://github.com/jquery/jquery/pull/4101 re-enable test in edge 17
  • LGTM
• https://github.com/jquery/jquery/pull/4098 Update node dependencies
  • Merging today
• https://github.com/jquery/jquery/pull/4108 jQuery.param(undefined)
  • Hope to merge today
• https://github.com/jquery/jquery/pull/4095
  • Seems fine
• https://github.com/jquery/jquery-wp-content/pull/414
  • Needs review

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, gibson042, jbedard, markelog, mgol Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4069 lockbot
  • https://github.com/jquery/jquery/pull/4070
    • Good to merge?
• https://github.com/jquery/jquery/pull/4096 width + SVG
• Node dependency refresh

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, gibson042, mgol, jbedard Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4069 lockbot
• https://github.com/jquery/jquery/pull/4070
  • Good to merge?
• https://github.com/jquery/jquery/pull/4064
  • LGTM
• https://github.com/jquery/jquery/pull/4028
  • Might need to pick this up
• https://github.com/jquery/jquery/pull/3902
  • Also getting stale

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, gibson042, dmethvin

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4083 $.type(async function)
  • close
• https://github.com/jquery/jquery/issues/4069 lockbot
  • https://github.com/jquery/jquery/pull/4070
    • LGTM
• https://github.com/jquery/jquery/issues/4081
  • close

link Mgol away May 3-31

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, jbedard, gibson042

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4039 GitHub license edits
  • Check in with Kris
• https://github.com/jquery/jquery/issues/3922 grunt infrastructure
  • Can this be closed? closed

link Mgol away May 3-31

link 3.4 Issues

• https://github.com/jquery/jquery/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+milestone%3A3.4.0

Attending: timmywil, mgol, jbedard, gibson042, markelog

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4039 GitHub license edits
  • Check in with Kris
• https://github.com/jquery/jquery/pull/4030
  • LGTM
• https://github.com/jquery/jquery/pull/4061 non-element prop + cssNumber + animate
  • LGTM
• https://github.com/jquery/jquery/pull/4055
• https://github.com/jquery/jquery/pull/4053

link Mgol away May 3-31

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, dmethvin, markelog, mgol, jbedard

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4039 GitHub license edits
  • Check in with Kris
• https://github.com/jquery/jquery/pull/4028 add grid props to cssNumber
  • Needs a test
• https://github.com/jquery/jquery/pull/4030
  • Reviews are in
• https://github.com/jquery/jquery/pull/4052 Support: expect at least one false
  • LGTM!
• https://github.com/jquery/jquery/issues/4040 Promise inconsistency?
  • Need gibson’s eyes
  • Looks valid
• The non-px-adding PR for https://github.com/jquery/jquery/issues/4009
  • An example list: https://gist.github.com/mgol/c14fcffb24cf9c2f08eca519f4dabd90

link Mgol away May 3-31

link WordPress jQuery update

• https://core.trac.wordpress.org/ticket/37110