Attending: timmywil, dmethvin, jbedard, markelog, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link Migrate failure

• http://swarm.jquery.org/job/5784
  • Dave working on PR
  • Failure in phantom
    • Something related to https://github.com/jquery/jquery/blob/master/src/manipulation.js#L64

link Core tests failing

• http://swarm.jquery.org/job/5741
  • Gibson working on a PR

link Dave having build issues

• Timmy to look into this

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/3700 content-box dimensions
  • Merged

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, dmethvin, jbedard, markelog, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3713
  • Remind me why we don’t use setProperty
  • Kebab-case
  • Switch to setProperty, inspect strings for !important$
  • Milestone: 3.4
• https://github.com/jquery/jquery/pull/3700 content-box dimensions
  • I’m back and forth on this one
• https://github.com/jquery/jquery/pull/3702 Deprecate jQuery.isWindow
  • Merged
• https://github.com/jquery/jquery/pull/3695 Offset: return mutable objects
  • Merged, with an issue. Now fixed (3717)

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, markelog, dmethvin, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/3700 IE9 + scrollbars + content-box
  • Let it fail?
    • Yea
• https://github.com/jquery/jquery/pull/3694 stop propagation on native events
  • OP has doubts, needs 2nd review
    • Still G2G
• https://github.com/jquery/jquery/issues/3704 $(‘*’) call stack exceeded
  • Can be done with a for loop. Is it worth it?
    • Check perf, but yes
• https://github.com/jquery/jquery/pull/3702 Deprecate jQuery.isWindow
  • LGTM!
• https://github.com/jquery/jquery/pull/3695 Offset: return mutable objects
  • LGTM

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, jbedard, dmethvin, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/3657 Deferred memory leak
  • Land
• https://github.com/jquery/jquery/pull/3695 Offset: return mutable objects
  • LGTM
• https://github.com/jquery/jquery/pull/3680 Build: add yarn.lock to gitignore
  • Needs an update
• https://github.com/jquery/jquery/pull/3669 Update easily-updatable dependencies
  • LGTM

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Should any of these be labeled blockers for 3.3?
    • Labeled blockers
• Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, dmethvin, jbedard, gibson042, markelog, mgol

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/3657 Deferred memory leak
  • LGTM, ok gibson?
  • approved
• https://github.com/jquery/jquery/issues/3693 stopPropagation not stopping native events
  • Sounds eerily familiar. Dave?
  • Dave to take a look
• https://github.com/jquery/jquery/issues/3689
  • Closed
• https://github.com/jquery/jquery/issues/3692
  • Closed

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, jbedard, gibson042, dmethvin, mgol, markelog

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/3680 npm 5 package-lock
  • Add yarn.lock to gitignore instead. We are usually the ones updating dependencies, so it would be nice to have the npm 5 lock file for idempotent installs for new users.
• https://github.com/jquery/jquery/pull/3657 Deferred memory leak
  • Needs review from gibson ✓
• https://github.com/jquery/jquery/issues/3646
• https://github.com/jquery/jquery.com/issues/162
  • "The 1.x and 2.x branches no longer receive patches" on homepage
  • mgol to open a PR

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, markelog, gibson042, mgol, jbedard

Location: https://gitter.im/jquery/meeting

• No meeting May 22 or May 29, Timmy on vacation, Memorial Day

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3664 disabled on anchor/click event
  • Don’t put disabled on an anchor
• https://github.com/jquery/jquery/pull/3656 include scroll gutter in width/height
  • LGTM
• https://github.com/jquery/jquery/pull/3657 Deferred memory leak
  • LGTM - I’m not sure how to test this cleanly either
  • Gibson to take a look
• https://github.com/jquery/jquery/pull/3661 IE/Edge support comments
  • LGTM
• https://github.com/jquery/jquery/pull/3666 param + array
  • Seems odd to get this now
  • Probably can’t change this

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Needs assignment
• https://github.com/jquery/jquery/issues/3606
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, mgol, jbedard, gibson042, markelog, dmethvin

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3642 math tag clone
  • Gibson042 to look into selector issue
• https://github.com/jquery/jquery/pull/3617 isFunction
  • Landed
• https://github.com/jquery/jquery/pull/3590 xhr: add ontimeout callback
  • LGTM
• https://github.com/jquery/jquery/pull/3569 CSS: drop float mapping
  • LGTM
• https://github.com/jquery/jquery/pull/3487 offset/position
  • Landed

link Edge testing - 14+ right now

link Consider dropping IE9/10 in jQuery 4.0.

• Coordinate with Angular, Ember, and other libs.

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
• Needs assignment
  • https://github.com/jquery/jquery/issues/3606
• Check your assignments. Pick up someone else’s if you have time. Assigned count:
  • timmywil: 11
  • dmethvin: 7
  • gibson042: 8
  • mgol: 3
  • markelog: 2
  • jbedard: 0

Attending: timmywil, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/3617 isFunction
  • Looks like some small changes suggested from markelog to finish before merge. Anything outstanding to talk about?
• https://github.com/jquery/jquery/pull/3590 xhr: add ontimeout callback
  • LGTM
• https://github.com/jquery/jquery/pull/3569 CSS: drop float mapping
  • LGTM
• https://github.com/jquery/jquery/pull/3487 offset/position
  • Ready to land?

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0

• Needs assignment

  • https://github.com/jquery/jquery/issues/3606

• Check your assignments. Pick up someone else’s if you have time. Assigned count:

  • timmywil: 11
  • dmethvin: 7
  • gibson042: 8
  • mgol: 3
  • markelog: 2
  • jbedard: 0

Attending: timmywil, gibson042, markelog, dmethvin

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3623 licensing
  • Can we close this?
  • Pinged legal, waiting for answer
• https://github.com/jquery/jquery/pull/3617 isFunction
  • Markelog approve?
• https://github.com/jquery/jquery/issues/3589 innerWidth + scrollbars
  • What’s the resolution here? Milestone?
  • Try gibson’s solution of using offsetWidth to calculate scrollbar width and include with padding where applicable

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
• Needs assignment
  • https://github.com/jquery/jquery/issues/3606
  • https://github.com/jquery/jquery/issues/3603
• Check your assignments. Pick up someone else’s if you have time. Assigned count:
  • timmywil: 11
  • dmethvin: 7
  • gibson042: 8
  • mgol: 3
  • markelog: 2
  • jbedard: 0