Attending: DaveMethvin, m_gol, gibson042, markelog, jbedard

link Issues needing review

• https://github.com/jquery/jquery/issues/3194
  • Seems bad to have load code run before ready code?
  • (attaching event outside ready seems okay to me tho)
  • Can Migrate detect this and warn about setting a load handler in a ready handler?
• https://github.com/jquery/jquery/issues/3193
  • Do we just live with this? If not, how do we "fix" it?
• https://github.com/jquery/jquery/issues/3187
  • Leave as a wontfix?
• https://github.com/jquery/jquery/issues/3174
  • readyList.then(fn).catch(err => jQuery.readyException(err)) or some such
  • Default would be to log and rethrow (so it remains unhandled)

link Angular issue

• https://github.com/angular/angular.js/blob/v1.5.7/src/angular.suffix
  • Init is wrapped in a ready and throw new Error() swallowed
  • Switching to always use ready-no-deferred would fix this?

link Should we move our wontfix page? (Dave)

• https://contribute.jquery.org/wont-fix/
• Maybe to our own repo's wiki? Seems related to the info there

link BrowserStack

• IE 6 automated tests removed completely -- YAY!
• https://jquery.com/upgrade-guide/3.0/#browser-support - the browser support changes policy - only on majors? Decide.

link 3.0.1

• Issues: https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.1

link What is codacy-bot and why is it talking on our PRs?

• Thoughts about whether this is useful?
  • It’s running on custom settings incompatible with our code… e.g. https://github.com/jquery/jquery/pull/3202/files/37e5e0d9f1c3f2261071019db84bf5e1f5e9135b#r68554905
  • Let's block it for now, we can do our own code complexity metrics

link Migrate

• 3.x
  • No critical issues for 3.0.1 yet
  • https://github.com/jquery/jquery-migrate/issues/198
  • m_gol any issues you've seen with Angular?

Attending: timmywil, DaveMethvin, gibson042, markelog, jbedard

link 3.0 Released!

• http://blog.jquery.com/2016/06/09/jquery-3-0-final-released/

link Issues needing review

• https://github.com/jquery/jquery/issues/3144 custom CSS properties

link 3.0.1

• Issues: https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.1
  • 3 need assignment
  • Anything to add to 3.0.1?

link Migrate

• 3.x
  • No critical issues for 3.0.1 yet
• https://github.com/jquery/jquery-migrate/issues/102
  • Let's wait for reports where it would have been useful

link jQuery 4.0 event changes WIP

• Using one aEL per jQuery event and native event object:
• https://github.com/dmethvin/jquery/commits/v4-native-events
• Seems to pass jQuery UI unit tests
• Not too many fails in our units: http://imgur.com/tewiRFR
• Issues with stopPropagation on delegated events, success depends on whether the delegated ones are attached first since we're doing 1:1 handlers
• Could we use a capturing handler somehow to fix this? (jbedard)
• Still need to review use of jQuery.event.special and .trigger()
• Can we use native event for .trigger() and not even do our own bubbling in most cases?

Attending: timmywil, m_gol, jbedard, gibson042, markelog

link TSC grouping

• Which projects do we collaborate (or want to collaborate) with most?
• https://github.com/jquery-foundation/CB
• Goals of TSC/CB: https://github.com/jquery-foundation/CB/issues/3

link PRs

• https://github.com/jquery/jquery/pull/3096 offset: relative to doc
  • Needs followup

link 3.0

• Mobile breakages
  • Mobile depends on $.event.props https://irc.jquery.org/%23jquery-dev/default_%23jquery-dev_20160602.log.html#t13:32:42

link 3.0 Upgrade Guide

• https://jquery.com/upgrade-guide/3.0/
  • Need an addition to https://jquery.com/upgrade-guide/ landing page

link Migrate

• 3.0.0
  • https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
  • https://github.com/jquery/jquery-migrate/issues/102

link Browserstack can drop their dedicated IE6 machine

Attending: timmywil, markelog, m_gol, gibson042

link 1.12.4, 2.2.4, and 3.0.0-rc1 released!

• Migrate 1.4.1 and 3.0.0-rc1 also released
• 3.0 final to be released after 2 weeks of RC

link 1.12-stable & 2.2-stable

• No more updates that aren’t at blocker priority

link 3.0 Upgrade Guide

• https://jquery.com/upgrade-guide/3.0/
  • Need an addition to https://jquery.com/upgrade-guide/ landing page

link 3.0 in popular frameworks/libraries

• Angular good
• Bootstrap checked (PR submitted)
• Ember?

link Migrate

• 3.0.0
  • https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
  • https://github.com/jquery/jquery-migrate/issues/102

link Drop yandex from Sizzle

link Allow Browserstack to drop dedicated IE6 machine next week

• This means stopping testing it in Core on 1.x-stable and in Sizzle on master

link No meeting next week

Attending: timmywil, markelog, DaveMethvin, jbedard, m_gol, gibson042

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.12.4%2F2.2.4
• https://github.com/jquery/jquery/pull/3121 Firefox focus PR
  • Apply this to all browsers? https://github.com/jquery/jquery/pull/3121#discussion_r63366420
    • yes

link 3.0 Upgrade Guide

• https://jquery.com/upgrade-guide/3.0/
  • Need an addition to https://jquery.com/upgrade-guide landing page
• PRs to land ASAP
  • https://github.com/jquery/jquery.com/pull/131
    • LGTM
  • https://github.com/jquery/jquery.com/pull/129
    • LGTM

link 3.0 in popular frameworks/libraries

• Bootstrap 4.0 beta seems to work with just one change to their unit tests
  • https://github.com/twbs/bootstrap/pull/19906
• Other libraries to check
  • Ember

link Migrate

• 3.0.0
  • https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
  • https://github.com/jquery/jquery-migrate/pull/192
  • https://github.com/jquery/jquery-migrate/issues/102
• 1.4.1
  • https://github.com/jquery/jquery-migrate/issues?q=milestone%3A1.4.1
  • Blog post explaining 1.4.1 and the relation to 3.0.0 (Dave has a draft)

Attending: timmywil, DaveMethvin, gibson042, jbedard, m_gol

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.12.4%2F2.2.4
• https://github.com/jquery/jquery/pull/3057
  • Will land today. Fixes 2 issues.
• https://github.com/jquery/jquery/issues/2945 webpack
  • sizzle -> external/sizzle
  • PR almost ready. Testing with jquery-release now.
• https://github.com/jquery/jquery/issues/3094 remove slim from 1.12/2.2 dist
  • Timmy to PR this week

link 3.0 Upgrade Guide

• https://jquery.com/upgrade-guide/3.0/
  • Should be up to date with all non-trivial changes now
• $ -> jQuery https://github.com/jquery/jquery.com/issues/130

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery/issues/3102 split jQuery.when
  • Okay to land? yes

link Android 2.3 support?

• Making it unofficial - we may fix critical issues but we won’t officially list this browser as supported

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery-migrate/issues/102
  • gibson042 can you describe a few cases here?
• https://github.com/jquery/jquery-migrate/issues/189 Fixhooks: Warn if used only with a filter
  • Dave to fix this week

Attending: timmywil, DaveMethvin, m_gol, gibson042

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.12.4%2F2.2.4
• https://github.com/jquery/jquery/issues/3065
  • Seems high priority for WordPress, discussion in IRC
  • http://irc.jquery.org/%23jquery-dev/default_%23jquery-dev_20160429.log.html#t16:02:40
  • Does https://github.com/jquery/jquery/pull/3057 fix?
    • Yes, but not the way we want. Timmy is 5min from a PR.
• https://github.com/jquery/jquery/issues/3043
  • Related to 3065? No
  • There are 2 issues. The IE8 path wasn’t accounting for disconnected nodes and modern browsers were failing the support test when certain global table CSS was on the page.

link 3.0 Upgrade Guide

• https://github.com/jquery/jquery.com/blob/master/pages/upgrade-guide/3.0.md
• https://jquery.com/upgrade-guide/3.0/
  • Should be up to date with all non-trivial changes now
• Potential additions?s
  • event fixHooks changes that we decide to land
  • jQuery.when changes from https://github.com/jquery/jquery/pull/3059

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery/pull/2860
  • How far should we go? Let's land at least the first part ASAP
• https://github.com/jquery/jquery/issues/3029 $.when().done() regression
  • gibson042

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
  • Switched to strict mode, following core
• https://github.com/jquery/jquery-migrate/issues/173
  • Needs a review, otherwise ready
• https://github.com/jquery/jquery-migrate/issues/102
  • gibson042 can you describe a few cases here?
  • Depending on which fixHook changes land we'll need changes there, jbedard proposed a Migrate fill
  • https://github.com/jquery/jquery/pull/2860#issuecomment-215652293

Attending: markelog, m_gol, DaveMethvin, gibson042

link Upgrade Guide

• Moved and rearranged content by subsystem and impact
• https://github.com/jquery/jquery.com/blob/master/pages/upgrade-guide/3.0.md
• https://jquery.com/upgrade-guide/3.0/
• Still need input and writeup on show/hide changes and remediation (gibson)
• Add note about strict mode if we decide that (dave)

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues/3041
  • m_gol will revert the hacky workaround
• https://github.com/jquery/jquery/issues/3043
  • .contains() check?

link 3.0

• Remove support for Yandex.Browser?
  • Browserstack isn't updating (2014 version)
  • May not be worth nagging them to update
  • Decided to remove support for 3.0
  • Markelog to update support matrix & remove from Swarm
• Switch to strict mode?
  • Yes
  • Bug and PR already exists for the Uglify bug we encountered
  • Need to strip out excess "use strict" as part of the fn wrappers
• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery/issues/3064 Revert easing param removal
  • Markelog
• https://github.com/jquery/jquery/issues/3056
  • Dave
  • Nvm, closed
• https://github.com/jquery/jquery/issues/3029 $.when().done() regression
  • gibson042

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• gibson042 to look at show/hide in Migrate
• Also should switch to strict mode if core does?

Attending: timmywil, markelog, m_gol, DaveMethvin, gibson042

link Upgrade Guide

• Still need input and writeup on show/hide changes and remediation (gibson)
• https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#
• gibson042 almost done with the writeup

link 1.12.4/2.2.4

• https://github.com/jquery/jquery/issues/3041 has IE 11 fixed the bug they promised not to fix?

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0

link JSHint, JSCS, ESLint

• Should we switch to ESLint completely?

link Issues needing review

• https://github.com/jquery/jquery/issues/2824 # in selectors
  • No revert
  • “be more careful with code changes that may introduce exceptions on invalid input, during code review, but not have a policy to test for invalid input”
  • “it doesn't mean we're not going to introduce exceptions, but we can make sure people have warning.” Moving an exception to major version may be appropriate.
• https://github.com/jquery/jquery/issues/3060 Remove default Deferred callback context
  • Yes

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
  • gibson042 to look at show/hide in Migrate

Attending: m_gol, gibson042, markelog, dmethvin, timmywil

link Upgrade Guide

• Still need input and writeup on show/hide changes and remediation (gibson)
• https://docs.google.com/document/d/1QLkXfuhsFAppsZbi_8UJV0LxjNKaQfHwXmSR5GLVWX4/edit#
• gibson042 almost done with the writeup

link 3.0

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• Down to 2!
• Blocker https://github.com/jquery/jquery/issues/3029 $.when(dfd).done() args
• Blocker https://github.com/jquery/jquery/issues/3010 dave to pester gdsmith but let's not call it a blocker

link PRs

• https://github.com/jquery/jquery/pull/3037 Toggle detached elements
  • LGTM

link Migrate

• https://github.com/jquery/jquery-migrate/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• https://github.com/jquery/jquery-migrate/issues/118
  • Dave will grab
• gibson042 to look at show/hide in Migrate