Attending: timmywil, mgol, jbedard, gibson042, markelog

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4039 GitHub license edits
  • Check in with Kris
• https://github.com/jquery/jquery/pull/4030
  • LGTM
• https://github.com/jquery/jquery/pull/4061 non-element prop + cssNumber + animate
  • LGTM
• https://github.com/jquery/jquery/pull/4055
• https://github.com/jquery/jquery/pull/4053

link Mgol away May 3-31

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, dmethvin, markelog, mgol, jbedard

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4039 GitHub license edits
  • Check in with Kris
• https://github.com/jquery/jquery/pull/4028 add grid props to cssNumber
  • Needs a test
• https://github.com/jquery/jquery/pull/4030
  • Reviews are in
• https://github.com/jquery/jquery/pull/4052 Support: expect at least one false
  • LGTM!
• https://github.com/jquery/jquery/issues/4040 Promise inconsistency?
  • Need gibson’s eyes
  • Looks valid
• The non-px-adding PR for https://github.com/jquery/jquery/issues/4009
  • An example list: https://gist.github.com/mgol/c14fcffb24cf9c2f08eca519f4dabd90

link Mgol away May 3-31

link WordPress jQuery update

• https://core.trac.wordpress.org/ticket/37110

Attending: timmywil, dmethvin, jbedard, mgol

Location: https://gitter.im/jquery/meeting

link Time to start grinding on 3.4

link Issues needing review

• https://github.com/jquery/jquery/issues/4039 GitHub license edits
• https://github.com/jquery/jquery/pull/3998 add code property to event object
  • LGTM, needs separate issue for jQuery.Event test
• https://github.com/jquery/jquery/pull/4028 add grid props to cssNumber
  • Land for 3.4, whitelist to come in 4.0
  • Ensure it’s not missing any grid props
• https://github.com/jquery/jquery/pull/4030
  • LGTM

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, markelog, jbedard, dmethvin, gibson042

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4026 select text of hidden textarea
• https://github.com/jquery/jquery/issues/4031 store dists publicly
  • I’ve used dropbox to create fiddles that confirm the fix. I question whether the effort is worth it.
• https://github.com/jquery/jquery/pull/4030 scrollbox + zoom
  • LGTM

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, dmethvin, jbedard, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/4009 deprecate px append
  • Can this just be tracked in migrate?
  • Open api ticket first
• https://github.com/jquery/jquery/issues/4021 :enabled:invalid
  • Why isn’t this going through qSA?
• https://github.com/jquery/jquery/issues/3950
  • Browserstack dropping emulators for android <=4.4
  • Manual testing for pre 4.0 releases
• https://github.com/jquery/jquery/pull/3996
  • Needs work
• https://github.com/jquery/api.jquery.com/pull/1049

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, dmethvin, jbedard, gibson042, mgol, markelog

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/pull/4010 avoid isBorderBox
  • LGTM
• https://github.com/jquery/jquery/issues/4009 deprecate px append
  • Perhaps needs some code to look at. This is a behavior change, but perhaps not one that is clear enough for a deprecation notice. In other words, it should be made clear that this will not affect the common CSS properties and will likely make no noticeable difference to most users.
  • Put together a whitelist proposal
• https://github.com/jquery/jquery/pull/4011 no sudo + travis
  • LGTM
• https://github.com/jquery/jquery/pull/4005 avoid cssProps
  • LGTM
• https://github.com/jquery/jquery/pull/3996
  • Needs work

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, gibson042, jbedard, mgol, markelog

Location: https://gitter.im/jquery/meeting

link Issues needing review

• https://github.com/jquery/jquery/issues/3991 isBorderBox + forced reflow
  • If the logic is functional, I’m fine with avoiding isBorderBox when possible
• https://github.com/jquery/jquery/pull/3977 isAttached
  • LGTM
• https://github.com/jquery/jquery/pull/3902 ajax URLs cache: false
  • The var files are unnecessary, but if gibson approves, that’s the only request from me.
  • Needs more changes
• https://github.com/jquery/jquery/pull/3868 change tests to html5
  • Yes, since the doctype we have actually triggers quirksmode!
  • Needs to change more doctypes
  • Address XHTML testing elsewhere

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, dmethvin, gibson042, jbedard, mgol

Location: https://gitter.im/jquery/meeting

link jQuery Migrate

• https://github.com/jquery/jquery/issues/3986 Don’t fill cssProps?
  • Use separate object for vendor props, so cssProps is solely for custom overrides and migrate can hate on it

link Issues needing review

• https://github.com/jquery/jquery/issues/3983 colon character in namespace
• https://github.com/jquery/jquery/issues/3988 height on td in IE/Edge
  • What to do here?
  • Closed. Open ticket on Edge
• https://github.com/jquery/jquery/issues/3989
  • Works for me in FF Quantum 58.0.2
  • Works for us on FF(Mac & Windows) and Edge

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, dmethvin, jbedard, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link jQuery Migrate

• https://github.com/jquery/jquery-migrate/issues
  • https://github.com/jquery/jquery-migrate/pull/289
  • https://github.com/jquery/jquery-migrate/pull/290
  • https://github.com/jquery/jquery-migrate/pull/291

link Issues needing review

• https://github.com/jquery/jquery/issues/3982 outerHeight, -margins
  • Fix
• https://github.com/jquery/jquery/issues/3969 getScript ‘unsafe-inline’
  • Two main concerns: using script tags for local scripts like we do with crossDomain scripts will avoid the CSP violation, but we also need to think about execution order in the case of script tags for when domManip executes scripts from HTML. Using script tags for local scripts will also fix the warning noted in the next issue (if async)----->
  • Can recommend crossDomain: true for their case as a workaround
• https://github.com/jquery/jquery/issues/3975 scripts in loaded HTML are sync

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can

Attending: timmywil, gibson042, markelog, mgol

Location: https://gitter.im/jquery/meeting

link jQuery Migrate

• https://github.com/jquery/jquery-migrate/issues
  • Grab an issue!

link Issues needing review

• https://github.com/jquery/jquery/issues/3969 getScript ‘unsafe-inline’
  • Two main concerns: using script tags for local scripts like we do with crossDomain scripts will avoid the CSP violation, but we also need to think about execution order in the case of script tags for when domManip executes scripts from HTML. Using script tags for local scripts will also fix the warning noted in the next issue (if async)----->
• https://github.com/jquery/jquery/issues/3975 scripts in loaded HTML are sync

link 3.4 Issues without assignment

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.4.0+no%3Aassignee
  • Pick one up if you can