October 30, 2017 Attending: timmywil, jbedard, mgol, markelog, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3822
  • Related to 3808?
• https://github.com/jquery/jquery/pull/3781
  • LGTM
• https://github.com/jquery/jquery/issues/3829
  • Close? yes
• https://github.com/jquery/jquery/issues/3828
  • Close? Can we workaround? close

link Content sites are hanging during deployment

• Update?
  • Contact Adam Ulvi or Alex Schmitz

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, jbedard, dmethvin, mgol

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3812
  • Didn’t reduce the test case. Ask again?
• https://github.com/jquery/jquery/issues/3822
  • Related to 3808?
• https://github.com/jquery/jquery/pull/3781
  • Ready for review

link Content sites are hanging during deployment

• Contact gnarf or scottgonzalez

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, dmethvin, jbedard, markelog, mgol, gibson042

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3812
• https://github.com/jquery/jquery/pull/3781
  • Add check for string

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

October 2, 2017 Attending: timmywil, gibson042, markelog

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3767 hosting tests
  • I’d like to close and say PRs welcome
• https://github.com/jquery/jquery/pull/3782 ajax: custom attributes
  • Needs an update
  • 1 attr call, similar to jbedard’s suggestion
  • Needs a corresponding support ticket
• https://github.com/jquery/jquery/pull/3781 ajax:
  • What this is really doing is not adding data to GET requests based on the processData option, whether the data is processed or not. I am semantically opposed to this change. :/

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3792 remove package-lock.json
  • Yes
• https://github.com/jquery/jquery/pull/3791 increase timeout for Promises/A+ tests
  • LGTM
• https://github.com/jquery/jquery/pull/3759 Fix uglifyjs output for android 4.0
  • Timmy to dive deeper this week.
• https://github.com/jquery/jquery/pull/3786 update babel
  • LGTM, has plugin

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, jbedard, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link Issues and PRs needing review

• https://github.com/jquery/sizzle/pull/407 Sizzle: using length in loops
  • LGTM
• https://github.com/jquery/jquery/pull/3778 CSS: webkit/%s
  • Fixes existing failure
  • LGTM
• https://github.com/jquery/jquery/issues/3438 processData: false
  • Maybe just copy/paste what jaubourg said to the docs. ;)
  • does processing an object at beforeSend have any advantages to working with the object before the calling ajax at all?
  • “we can fix it by updating processData documentation to make it clear that data will always be converted into query parameters for no-body request types” - gibson, timmy
  • Ask Dave
• https://github.com/jquery/jquery/pull/3766 noonce attr
  • Better: https://github.com/jquery/jquery/pull/3782
  • Jaubourg has suggestions
• https://github.com/jquery/jquery/pull/3786 update babel
  • This is just for our for-of test

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, jbedard, markelog, gibson042, dmethvin

Location: https://gitter.im/jquery/meeting

link Migrate

• https://github.com/jquery/jquery-migrate/pull/264
  • Merged with followup

link Npmcopy

• Perhaps it’s time to get rid of grunt-npmcopy

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3764 key property
  • Making sure we agree to close. closed
• https://github.com/jquery/jquery/issues/3767 XSS?
  • I don’t think we need to guard against this. Closed
• https://github.com/jquery/jquery/pull/3778 CSS: webkit/%s
  • Reviews requested

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, markelog, gibson042, mgol

Location: https://gitter.im/jquery/meeting

link Migrate

• https://github.com/jquery/jquery-migrate/pull/264
  • Good to merge?

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3764 normalize event.key
  • Do we want to do this? Probably not
• https://github.com/jquery/jquery/pull/3766 nonce on script tags
  • Needs review
  • Can be reduced
• https://github.com/jquery/jquery/pull/3744 grunt karma (sans ajax)
  • Has been updated.
• https://github.com/jquery/jquery/pull/3745

• LGTM

• https://github.com/jquery/jquery/issues/3743 swarm android 4.0 timeouts
  • https://github.com/jquery/jquery/pull/3759
  • Needs further research. ie8: true is a last resort.
• https://github.com/jquery/jquery/issues/3742 Android 4.0: 1 ajax failure
  • Timmy to look
• https://github.com/jquery/sizzle/pull/399?
  • OK to land? yes
• https://github.com/jquery/sizzle/issues/402
  • closed

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, mgol, gibson042, markelog

Location: https://gitter.im/jquery/meeting

link Migrate

• https://github.com/jquery/jquery-migrate/pull/264
  • Good to merge?

link Issues and PRs needing review

• https://github.com/jquery/jquery/pull/3744 grunt karma (sans ajax)
  • Needs review
• https://github.com/jquery/jquery/pull/3745
  • Needs review
• https://github.com/jquery/jquery/issues/3743 swarm android 4.0 timeouts
  • Do we know the fix here? Mgol to look next week
• https://github.com/jquery/jquery/issues/3742 Android 4.0: 1 ajax failure
  • Timmy to look

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.

Attending: timmywil, gibson042, jbedard

Location: https://gitter.im/jquery/meeting

link Migrate

• https://github.com/jquery/jquery-migrate/pull/264
  • Needs more reviews

link Issues and PRs needing review

• https://github.com/jquery/jquery/issues/3646
  • Are we unwrapping thenables?
• https://github.com/jquery/jquery/pull/3744 grunt karma (sans ajax)
  • Needs review
• https://github.com/jquery/jquery/pull/3745
  • Needs review

link 3.3 issues

• https://github.com/jquery/jquery/issues?page=1&q=is%3Aopen+is%3Aissue+milestone%3A3.3.0
  • Check your assignments. Pick up someone else’s if you have time.