Minutes (Notes) of the meeting of jQuery

Location: #jquery-meeting on Freenode

Time: Noon ET

Official Agenda:

jQuery 1.6.1 Status

Blocker Status: http://bugs.jquery.com/query?status=!closed&milestone=^1.6.1&order=priority

Unhandled exception: document.defaultView.getComputedStyle(div, null) is null (FF, hidden iframe)

• https://github.com/jquery/jquery/pull/370
• Julian will add some tests

when hover over a child of an element, mouseleave fires when using live or delegate

• John fixed this.

Order of hide() callbacks has changed

• https://github.com/jquery/jquery/pull/374

Changes to $.data illogical in certain case

• John fixed this.

:reset pseudo-selector broken

• John: I got this.

Release Dates:

• RC on Tuesday the 10th
• Final on Thursday the 12th

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: Noon ET

Official Agenda:

• jQuery 1.6 Status

  • Docs status

    • Good shape, .pipe() is left as are some of the hooks

  • Blog Post

    • Features

      • Attribute and Val Rewrite

        • Hooks
        • Performance Improvements
        • Property Methods
          • .prop(), .removeProp() (Dave has this)

      • .find(), .closest() , and .is()with DOM elements and jQuery objects

      • .css() relative values

      • :focus selector

      • Synced Animations

        • Also: requestAnimationFrame

      • Using Function.prototype.bind

      • jQuery.map object

      • Deferreds (Julian has this)

        • .promise()
        • deferred.always()
        • deferred.pipe()

      • Breaking Changes

        • Should this be integrated into the attribute section?
        • (Dave has this) —> My text:
        • https://docs.google.com/document/d/1Oit_IX1xZg7wRcmpPPrtoqv6wIbnlJB9YBxn-EnZOxE/edit?hl=en&authkey=CMmB-rMP#

    • Performance Improvements

      • .attr(“get”) and .attr(“name, “set”)

        • http://jsperf.com/attr-vs-attrhooks

      • .val(“get”)

        • http://jsperf.com/valhooks-vs-val/2

      • .data() / .trigger()

        • http://jsperf.com/jq152-vs-jq16pre-trigger/3

    • Accepting Feature Requests for 1.7

      • https://spreadsheets.google.com/viewform?hl=en&authkey=CPmgicsO&formkey=dG0yTEs2ZTFWQUhDRUp5dzRyc3NwV2c6MA#gid=0

  • Blocker Status

    • http://bugs.jquery.com/report/207
      • jQuery doesn’t parse html from string correctly!
        • John: Fixed

  • Release Dates:

    • Final: Tuesday the 3rd

• Coverage analysis of jQuery documentation:

  • http://test.learningjquery.com/jquery-methods.html

Minutes (Notes) of the meeting of jQuery

Location: #jquery-meeting on Freenode

Time: Noon ET

Official Agenda:

• jQuery 1.6 RC

  • Docs status

  • Blocker Status

    • http://bugs.jquery.com/report/207
    • Duplicate mouseover and mouseout events added to cloned element. — still working on this one, seems to have been around a while
      • Bumping to 1.7

  • Release Dates:

    • RC: Tuesday the 26th
    • Final: Tuesday the 3rd

• Coverage analysis of jQuery documentation:

  • http://test.learningjquery.com/jquery-methods.html

• Merging Pull Requests

  • http://ejohn.org/blog/pulley/
  • https://github.com/blog/843-the-merge-button

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: 2pm ET
NOTE: This meeting has been moved to Wednesday to avoid conflicts with the jQuery Conference.

Official Agenda:

• jQuery 1.6 RC

  • Problems with the beta?

  • Docs status

  • Blocker Status

    • http://bugs.jquery.com/query?status=!closed&milestone=^1.6&report=207&order=priority
    • Duplicate mouseover and mouseout events added to cloned element.
    • Setting checked to true on a disconnected checkbox does not carry over after attaching to DOM.
    • live(“hover”, … ) broken in 1.5.1
    • Leak with events in IE

  • Release Dates:

    • RC: Tuesday the 26th
    • Final: Tuesday the 3rd

• 1.7 spreadsheet will be available with 1.6 release

• Pull Request Review

  • Fix 6782 – Optimize regex for innerHTML to allow more html snippets to use faster method

    • Patch appears to be in limbo? Dave, do you have this one?
    • http://bugs.jquery.com/ticket/6782

  • Fix for bug 6593

    • John: Needs some tests and code cleanup
    • http://bugs.jquery.com/ticket/6593

  • #7061 – In IE form isn’t submitted when disabling submit button in submit callback

    • John: Seems like this might do the trick? Recommending a possible code reorg.
    • http://bugs.jquery.com/ticket/7061

• Possible 1.7 Pull Requests

  • Synchronousslots

    • Is this a 1.7 thing? Is this needed with the recent effects changes?
    • http://bugs.jquery.com/ticket/6281

  • Ticket #8498: Animating margin/padding can cause flashes when margins are set using left/right/top/bottom

    • Sounds like this should be converted into a “CSS shorthand” thing used by both .css() and .animate(). Push to 1.7?
    • http://bugs.jquery.com/ticket/8498

  • Bug 4446 – Add selector support to .andSelf()

    • Push to 1.7?
    • http://bugs.jquery.com/ticket/4446

  • #5479 – Allow passing multiple attributes to removeAttr

    • Push to 1.7?
    • http://bugs.jquery.com/ticket/5479

  • #7323 – Allow removing multiple data keys at once with $.fn.removeData

    • Push to 1.7?
    • http://bugs.jquery.com/ticket/7323

  • Add support for registering jQuery as an AMD module

    • http://bugs.jquery.com/ticket/7102

Best way to merge Pull Requests?
 
jQuery commit commands
 
git checkout master
git checkout -b bug1234
git pull http://url/to/otherrepo branchname
git checkout master
git merge --no-commit --squash bug1234
git commit -a --author="Original Author <author@email.example>"
 
To get the author:
git log | grep "Author" | head -1

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: Noon ET

Official Agenda:

• 1.6pre!!! http://bit.ly/hBxZyG

• Timeline

  • beta release of 1.6 on April 15th

• Last chance to get some bugs fixed for 1.6beta ( old open tickets )

• API changes

  • .chain has been renamed to .pipe to link deferreds

• Done and merged into master

  • 2 (danheberden, jaubourg): Have .animate() implement a deferred object

    1. bulk of implementation committed.
    2. STILL PENDING waiting on commits for un-queued animations

  • 5 (jaubourg): Do support tests in an iframe document (or maybe use false body element)

  • 13 (john): Add :focus to Sizzle

    1. http://bugs.jquery.com/ticket/8105

  • 14 (rwaldron): Allow properties to be passed in to $.Event() constructor

    1. https://github.com/jquery/jquery/pull/301

  • 15 (dmethvin): Perf improvements for .data() events — in general, we won’t fire data events if nobody attached a handler (detected by jQuery.event.global count).

    1. http://bugs.jquery.com/ticket/8790

    2. Need a review … I would prefer to “blacklist” natural events (click, mouseover, etc) so customs would all be faster, but it’s a long list: https://github.com/dmethvin/jquery/tree/fix-8790-quick-trigger

       • John: Can you do a pull request for this so that the diff is easier to see?

    3. Someone that uses dataEvents:

    4. https://github.com/jswartwood/jQuery-dataDefer

  • 16 (danheberden): Optimize validation in parseJSON

    1. https://github.com/jquery/jquery/pull/300

  • 17 (rwaldron): Fix event firing order Turns out this is a branch of #7340, which is Dave Methvin’s

  • 21 (dmethvin): Refactor jQuery.event.trigger/handle — Branch is passing unit tests; landed 4/6.

    1. http://jsperf.com/jq152-vs-jq16pre-trigger/3

  • 22 (dmethvin): Issue with triggering of focusin – may be fixed by pull 260, need to check with Joern who reported a problem i couldn’t repro Fixed in 1.5.2

  • 23 (timmywil): Allow .is(), .find(), and .closest() to accept nodes

    1. https://github.com/jquery/jquery/pull/206
    2. https://github.com/jquery/jquery/pull/283

  • 31 (jaubourg): Synchronize animations based upon start time (Thunderdome!)

    1. https://github.com/jquery/jquery/tree/synchro-anim.1.6

  • 34 (timmywil, john): attrHooks

    1. https://github.com/jquery/jquery/pull/296

       • note this is going into the attrhooks.1.6 branch

    2. http://bugs.jquery.com/ticket/3685 DOM0, Prehistoric document.forms API issue

    3. https://public.etherpad-mozilla.org/p/attrhooks-bugs

    4. http://jsperf.com/attr-vs-attrhooks

  • 36 (lrbabe, timmywill): Use requestAnimationFrame *Special attention to optimizing size

    1. https://github.com/jquery/jquery/pull/216 original
    2. https://github.com/jquery/jquery/pull/298timmywill revisions
       • John reviewed: needs minor tweak

• 38 (danheberden): $.map() working on objects

  1. https://github.com/jquery/jquery/pull/299

• 39 (rwaldron): .undelegate() doesn’t work on custom namespaced events

  1. http://bugs.jquery.com/ticket/8777
  2. https://github.com/rwldrn/jquery/tree/8777
  3. https://github.com/jquery/jquery/pull/302
     • John: Looks ok to me, landing.

42 (timmywil): .closest() fails on disconnected nodes

1. https://github.com/jquery/jquery/pull/291

46 (john): jQuery throwing error on replaceWith

52 (gf3, cowboy): Add Function.prototype.bind() support to jQuery.proxy

1. https://github.com/jquery/jquery/pull/133

51 (danheberden): Support relative values for .css()

1. https://github.com/jquery/jquery/pull/78 original
2. We wanted to see this patch DRY’ed out a bit, but we discussed in meeting and determined that it would probably introduce overhead to share this code between modules, and it’s not that much repeated code.  consensus was in favour of landing as-is. Dan is going to clean up the code a bit more.
3. https://github.com/jquery/jquery/pull/297

valHooks (the more modest version)?

1. https://github.com/jquery/jquery/pull/295

   • John: Looks good to me!

2. http://jsperf.com/jq152-vs-jq16pre-trigger/3

Bumped to 1.6.x / 1.7

• 10 (dmethvin): Optimize RegExp used for innerHTML shortcut (#6782, pull 248)
  1. This wants to add <select> to the list; need to see if selectedIndex still retained when we do that.
  2. https://github.com/jquery/jquery/pull/248
  3. http://bugs.jquery.com/ticket/6782
     • Needs more testing, bumping to a 1.6.x release.

20 (dmethvin): Attach data cache directly to element — In process, need to create separate list for global events.

1. Eventually  (1.7?) we will only support firing ajax* events on document and remove global events entirely.
2. http://bugs.jquery.com/ticket/8792

45 (jboesch, reviewed by john): Make .width() work correctly for inputs

1. http://bugs.jquery.com/ticket/4146

2. https://github.com/jquery/jquery/pull/253

   • John reviewed: Needs formatting fixes and possibly a code fix

3. also fixes http://bugs.jquery.com/ticket/3333 ?

Check it out: http://twitter.com/jqcommit

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: Noon ET

Official Agenda:

• Q&A – jswartwood & dataEvents ( someone is actually using them )

• Bug Triage Sprint was a big success, cleared out unreviewed tickets

  • Focus now is on clearing out old open tickets

• Should we re-consider:

  • valHooks (the more modest version)?

    1. https://github.com/jquery/jquery/pull/295

  • Deferred.chain/Deferred.always?

    1. https://github.com/jquery/jquery/commits/deferred.1.6
    2. .always seems like a wise idea to land
    3. http://forum.jquery.com/topic/a-case-for-deferred-chain

  • When do we we move features into master for alpha testing/release?

  • jQuery 1.6 Status ( beta release of 1.6 on April 15th )

    • 2 (danheberden, jaubourg): Have .animate() implement a deferred object

      1. works for queued animations, not for un-queued.

    • 5 (jaubourg): Do support tests in an iframe document (or maybe use false body element)

    • 10 (dmethvin): Optimize RegExp used for innerHTML shortcut (#6782, pull 248) — This wants to add <select> to the list; need to see if selectedIndex still retained when we do that.

    • 13 (john): Add :focus to Sizzle

    • 14 (rwaldron): Allow properties to be passed in to $.Event() constructor

      1. https://github.com/jquery/jquery/pull/301

    • 15 (dmethvin): Perf improvements for .data() events — in general, we won’t fire data events if nobody attached a handler (detected by jQuery.event.global count).

    • 16 (danheberden): Optimize validation in parseJSON

      1. https://github.com/jquery/jquery/pull/300

    • 17 (rwaldron): Fix event firing order Turns out this is a branch of #7340, which is Dave Methvin’s

    • 20 (dmethvin): Attach data cache directly to element — In process, need to create separate list for global events. Eventually  (1.7?) we will only support firing ajax* events on document and remove global events entirely.

    • 21 (dmethvin): Refactor jQuery.event.trigger/handle — Branch is passing unit tests; landed 4/6.

    • 22 (dmethvin): Issue with triggering of focusin – may be fixed by pull 260, need to check with Joern who reported a problem i couldn’t repro Fixed in 1.5.2

    • 23 (timmywil): Allow .is(), .find(), and .closest() to accept nodes

      1. https://github.com/jquery/jquery/pull/206
      2. https://github.com/jquery/jquery/pull/283

    • 31 (jaubourg): Synchronize animations based upon start time (Thunderdome!)

      1. https://github.com/jquery/jquery/tree/synchro-anim.1.6

    • 34 (john): attrHooks

      1. http://bugs.jquery.com/ticket/3685 DOM0, Prehistoric document.forms API issue
      2. https://public.etherpad-mozilla.org/p/attrhooks-bugs

    • 36 (lrbabe, timmywill): Use requestAnimationFrame *Special attention to optimizing size

      1. https://github.com/jquery/jquery/pull/216 original
      2. https://github.com/jquery/jquery/pull/298timmywill revisions

    • 38 (danheberden): $.map() working on objects

      1. seems pretty close to ready according to dan
      2. https://github.com/jquery/jquery/pull/299

    • 39 (rwaldron): .undelegate() doesn’t work on custom namespaced events

    • 42 (timmywil): .closest() fails on disconnected nodes

      1. https://github.com/jquery/jquery/pull/291

    • 45 (john): Make .width() work correctly for inputs

    • 46 (john): jQuery throwing error on replaceWith

    • 51 (danheberden): Support relative values for .css()

      1. https://github.com/jquery/jquery/pull/78 original
      2. We wanted to see this patch DRY’ed out a bit, but we discussed in meeting and determined that it would probably introduce overhead to share this code between modules, and it’s not that much repeated code.  consensus was in favour of landing as-is. Dan is going to clean up the code a bit more.
      3. https://github.com/jquery/jquery/pull/297
      • • 52 (gf3, cowboy): Add Function.prototype.bind() support to jQuery.proxy
          1. https://github.com/jquery/jquery/pull/133

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: Noon ET

Official Agenda:

• 1.5.2 Blocker Status

  • http://bugs.jquery.com/report/205

  • Release on the 31st

  • Bugs:

    1. Firefox: uncaught exception at line 1285

  • Bug Triage on Wednesday (11am EST)

    • Adam, Rick, John, Ben all together in Boston, everyone else, please help from your internet (Julian is helping from the net)

  • jQuery 1.6 Status ( beta release of 1.6 on April 15th )

    • 2 (danheberden, jaubourg): Have .animate() implement a deferred object

    • 5 (jaubourg): Do support tests in an iframe document (or maybe use false body element)

    • 10 (dmethvin): Optimize RegExp used for innerHTML shortcut (#6782, pull 248)

    • 13 (john): Add :focus to Sizzle

    • 14 (rwaldron): Allow properties to be passed in to $.Event() constructor

    • 15 (dmethvin): Perf improvements for .data() events

    • 16 (danheberden): Optimize validation in parseJSON

    • 17 (rwaldron): Fix event firing order

    • 20 (dmethvin): Attach data cache directly to element

    • 21 (dmethvin): Refactor jQuery.event.trigger/handle

    • 22 (dmethvin): Issue with triggering of focusin – may be fixed by pull 260, need to check with Joern who reported a problem i couldn’t repro

    • 23 (timmywil): Allow .is(), .find(), and .closest() to accept nodes

      1. Pull request is ready

    • 31 (jaubourg): Synchronize animations based upon start time (Thunderdome!)

    • 34 (john): attrHooks

      1. http://bugs.jquery.com/ticket/3685 DOM0, Prehistoric document.forms API issue
      2. https://public.etherpad-mozilla.org/p/attrhooks-bugs

    • 36 (lrbabe): Use requestAnimationFrame *Special attention to optimizing size

    • 38 (danheberden): $.map() working on objects

    • 39 (rwaldron): .undelegate() doesn’t work on custom namespaced events

    • 42 (timmywil): .closest() fails on disconnected nodes

    • 45 (john): Make .width() work correctly for inputs

    • 46 (john): jQuery throwing error on replaceWith

    • 51 (ajpiano): Support relative values for .css()

    • 52 (gf3, cowboy): Add Function.prototype.bind() support to jQuery.proxy

  • New feature requests: will not be landed for 1.6

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: Noon ET

Official Agenda:

• 1.5.2 Blocker Status

  • http://bugs.jquery.com/report/205

  • RC on the 24th

  • Release on the 31st

  • Bugs:

    1. $(‘:text’) should match <input> since `type=text` is the implied default (john)
    2. .is(“div”) fails on disconnected elements in IE9 (john)
    3. [ firefox] jquery >= 1.5 won’t work with flowplayer tooltip (dmethvin)
    4. Also: http://bugs.jquery.com/ticket/8316

  • jQuery 1.6 Status

    • 2 (danheberden, jaubourg): Have .animate() implement a deferred object

    • 5 (jaubourg): Do support tests in an iframe document (or maybe use false body element)

    • 10 (dmethvin): Optimize RegExp used for innerHTML shortcut (#6782, pull 248)

    • 13 (john): Add :focus to Sizzle

    • 14 (rwaldron): Allow properties to be passed in to $.Event() constructor

    • 15 (dmethvin): Perf improvements for .data() events

    • 16 (danheberden): Optimize validation in parseJSON

    • 17 (rwaldron): Fix event firing order

    • 20 (dmethvin): Attach data cache directly to element

    • 21 (dmethvin): Refactor jQuery.event.trigger/handle

    • 22 (dmethvin): Issue with triggering of focusin – may be fixed by pull 260, need to check with Joern who reported a problem i couldn’t repro

    • 23 (timmywil): Allow .is(), .find(), and .closest() to accept nodes

      1. A solution for find has been found, closest is coming along

    • 31 (jaubourg): Synchronize animations based upon start time (Thunderdome!)

    • 34 (john): attrHooks

      1. http://bugs.jquery.com/ticket/3685 DOM0, Prehistoric document.forms API issue
      2. https://public.etherpad-mozilla.org/p/attrhooks-bugs

    • 36 (lrbabe): Use requestAnimationFrame *Special attention to optimizing size

    • 38 (danheberden): $.map() working on objects

    • 39 (rwaldron): .undelegate() doesn’t work on custom namespaced events

    • 42 (timmywil): .closest() fails on disconnected nodes

    • 45 (john): Make .width() work correctly for inputs

    • 46 (john): jQuery throwing error on replaceWith

    • 51 (ajpiano): Support relative values for .css()

    • 52 (gf3, cowboy): Add Function.prototype.bind() support to jQuery.proxy

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: Noon ET

Official Agenda:

• 1.5.2 Blocker Status

  • Delayed discussion until next week

• jQuery 1.6 Roadmap

  • https://spreadsheets.google.com/ccc?key=0AuWerG7Xqt-8dDcwNUlSaWltOWJrNE5tOUlIbkVJbGc&hl=en&authkey=CIjOo7UK#gid=0

  • Be sure to land this in branches

    1. Will be pulled into core after 1.5.2 is out

  • A: Solid agreement, with owner or pull request:

    1. 2 (danheberden, jaubourg): Have .animate() implement a deferred object
    2. 5 (jaubourg): Do support tests in an iframe document (or maybe use false body element)
    3. 10 (dmethvin): Optimize RegExp used for innerHTML shortcut (#6782, pull 248)
    4. 13 (john): Add :focus to Sizzle
    5. 14 (rwaldron): Allow properties to be passed in to $.Event() constructor
    6. 15 (dmethvin): Perf improvements for .data() events
    7. 16 (danheberden): Optimize validation in parseJSON
    8. 17 (rwaldron): Fix event firing order
    9. 20 (dmethvin): Attach data cache directly to element
    10. 21 (dmethvin): Refactor jQuery.event.trigger/handle
    11. 22 (dmethvin): Issue with triggering of focusin – may be fixed by pull 260, need to check with Joern who reported a problem i couldn’t repro
    12. 23 (timmywil): Allow .is(), .find(), and .closest() to accept nodes
    13. 31 (lrbabe and/or gnarf and/or jaubourg): Synchronize animations based upon start time (Thunderdome!)
    14. 34 (john): attrHooks
    15. 36 (lrbabe): Use requestAnimationFrame *Special attention to optimizing size
    16. 38 (danheberden): $.map() working on objects
    17. 39 (rwaldron): .undelegate() doesn’t work on custom namespaced events
    18. 42 (timmywil): .closest() fails on disconnected nodes
    19. 45 (john): Make .width() work correctly for inputs
    20. 46 (john): jQuery throwing error on replaceWith
    21. 51 (ajpiano): Support relative values for .css()
    22. 52 (gf3, cowboy): Add Function.prototype.bind() support to jQuery.proxy

  • Good, but requires more discussion for potential 1.6 inclusion:

    1. 3 (jaubourg): Add chaining to promisHes
    2. 7: Solution for HTML 5 in IE
    3. 25 (timmywil): Add .valHooks

  • Tabled until 1.7:

    1. 6: Expose the data conversion interface from $.ajax()
    2. 11: Comprehensive and official support of file:
    3. 37: Use the same event object when bubbling native events, or preserve data relative to the event.

  • How was the decision made:

    1. Virtually all green = Solid Agreement
    2. Majority green = Mixed agreement
    3. Majority red / little green = Rejected

Minutes (Notes) of the meeting of jQuery
Location: #jquery-meeting on Freenode
Time: Noon ET

Official Agenda:

• 1.5.2 Blocker Status

  • http://bugs.jquery.com/report/205

  • Open Blockers:

    1. .focus() not triggering focusin event for .live binding (1.4.3)? (Dave)

    2. $(‘:text’) should match <input> since `type=text` is the implied default (John)

    3. .is(“div”) fails on disconnected elements in IE9 (John)

    4. trigger(‘mouseover’) no longer triggers mouseenter (Dave)

    5. Issues with focusin/focusout (Dave)

       http://bugs.jquery.com/ticket/7340

  • Any other possible blockers?

    1. Special events are not being cloned properly

       http://bugs.jquery.com/ticket/8397

       http://bugs.jquery.com/ticket/7037

    2. May have to wait for 1.6

    3. Release Date

       • 1. Release on 31st
         2. RC on the 24th

       • 1.6 Roadmap Discussion

         • https://spreadsheets.google.com/ccc?key=0AuWerG7Xqt-8dDcwNUlSaWltOWJrNE5tOUlIbkVJbGc&hl=en&authkey=CIjOo7UK

         • We may need to continue collecting feedback over the next week

           1. Need feedback from Jitter and SnoverDIDIT
           2. Need more feedback from Dave and Julian

         • Form is closing at the END OF THE DAY