Category: jQuery Core Team

Minutes from jQuery Core Team meetings

jQuery Core Team Meeting – Sep 29 2014

Attending: DaveMethvin, timmywil, jaubourg, gibson042

link Update on web site attacks

link Trac

  • Let's switch to Github issues
  • Infra team swamped with DDoS and hack attacks
  • Keeping Trac for old issues reference
    • turn off new account creation and anonymous add/comment (dave)
  • Trac 1.0 upgrade will happen when it happens
  • Migrate open issues to GH issues?
    • no, just close them via the current GH hook
  • Create new issues with GH issues
    • turn on gh issues (dave)
    • create tags/milestones

link Promise Error telemetry

  • mikesherov will talk to Domenic

link Promises/A+ compat

  • needs review
  • should this deliver to the .then? It doesn't currently because the .done throws
    • Deferred().done(f1).then(f2)
  • gibson042 proposing a change for that

link $.xhr

jQuery Core Team Meeting – Sep 22 2014

Attending: DaveMethvin, markelog, jaubourg, gibson042, mikesherov

link Trac

  • just about at the end of the line if it doesn't get fixed soon
  • we will switch to gh issues next week if trac has no progress

link Promise Error telemetry

  • Domenic proposed unhandled rejected promises go thru window.onerror
  • he actually preferred a separate handler for it tho
  • which should we back?
  • mikesherov will talk to Domenic this week

link Promises/A+ compat

  • jaubourg is working on it

link $.xhr

  • markelog and gibson042 to create some examples based on typical ajax usage
  • emails going out to core mailing group, with gists of sample usage
  • jQuery.ajax docs have some good examples

link https://github.com/jquery/jquery/pull/1652#issuecomment-56127735

  • bring back clear/mergeAttributes, gibson042 is on it
  • doing some perf tests to see impact

jQuery Core Team Meeting – Sep 15 2014

Attending: DaveMethvin, gibson042, mikesherov

Note: Timmy on vacation Aug 31-Sept 21

link Trac

  • I will ping about that, i think they made progress last week

link Promises/A+ compat for jaubourg's pull request

  • m_gol got it mostly working
  • some fails related to invalid args
  • need a solution for dfd.done( fnThrows ).then( neverCalled )
    • keep a separate list of callbacks for .then() vs .done()?
  • need analog to Promise.unhandledRejection proposal from Domenic
  • see if jauborg and m_gol can finish this
  • Promises error telemetry - Mike to reach out to Domenic

link $.xhr

  • markelog and gibson042 to create some examples based on typical ajax usage
  • review at next meeting

jQuery Core Team Meeting – Sep 11 2014

Location: In person, Chicago jQCon

Attending: DaveMethvin, markelog, gibson042, m_gol

link Versioning

  • If we are going npm we should obey semantic versioning
  • The .then() change will be breaking
  • Might as well remove other things like .andSelf()
  • New versioning
    • 1.x now jquery-legacy-3.x
    • 2.x now jquery 3.x

link Deferred pull request for Promise/A compat on .then()

link xhr

  • Design goal: allow standalone usage
  • Simple xhr module in a wrapper
1
2
3
4
5
6
7
8
9
10
 
jQuery.xhr = require("jquery-xhr");
jQuery.xhr.Promise = window.Promise || function( executor ) {
    var dfd = jQuery.Deferred();
    try {
        executor( dfd.resolve, dfd.reject );
    } catch ( ex ) {
        dfd.reject( ex );
    }
    return dfd.promise();
};
  • Simple case: jQuery.xhr( url, options ).then( handlerA ).then( handlerB )
  • beforeSend case:
1
2
3
4
5
 
xhr = jQuery.xhr( url, { autosend: false } ).set( … );
jQuery.xhr({ url: ... });
jQuery.xhr( url );
xhr.then( handlerA );
xhr.send( body ).then( handlerB )
  • Super-advanced case:
1
2
3
4
5
6
 
xhr = jQuery.xhr( url, { autosend: false } );
xhr.then( handlerA );
if ( badFeeling(xhr.getNative()) ) { xhr.abort(); }
xhr.send( body ).then( handlerB );
Promise.resolve( xhr ).then( … )
jQuery.xhr( url ).send({ ... }), jQuery.xhr( url )
  • Does an unsent Promise that has mutability violate the Promise/A+ spec? Or does the mutability only apply to the resolution? No. Does not appear to apply to the returned promise, which can be augmented, only to the resolved value of the promise
  • options necessary to functionality: method, user, pass, body, query (RFC), beforeSend
  • options nice to keep: cache, ifModified, headers
  • jxrPromise: .abort(), .xhr property
    • Rejects on: Exception, timeout, abort
  • what about 4xx/5xx? or a 0 (network error)
    • implied success: jQuery.xhr( url ).then( jQuery.xhr.rejectHTTPError )
    • implied failure: jQuery.xhr( url ).catch( jQuery.xhr.ifResponse )
  • Resolved value: raw native xhr
  • Rejected value: Error object, potentially with .xhr property, .options object

jQuery Core Team Meeting – Sep 01 2014

Attending: DaveMethvin, markelog, gibson042,

Note: Timmy on vacation Aug 31-Sept 21

link Trac

  • Volunteers are making progress on new setup
  • Had two new volunteers, including a Trac core contributor

link Promise/A+ compat

  • gibson042 proposal seems like it should work!
  • Checking with jaubourg on his availability, markelog and gibson042 are interested

link $.xhr

  • Build options object interface
  • Below it is a chaining interface?
    • exposes (not wraps) underlying xhr method
  • limited compat with old IE and ActiveX method?
    • (See discussion in IRC)

link Pull Requests

  • Please review and comment
  • markelog to land a few today
  • gibson042 and dmethvin to work on them tomorrow

link Tickets

jQuery Core Team Meeting – Aug 18 2014

Attending: DaveMethvin, markelog, gibson042, m_gol, jaubourg (12:20)

link Note: Dave on vacation Aug 21-25

link Trac

  • Volunteers are making progress on new setup
  • Let's give it a few weeks
  • Github issues is still an option IMO if Trac stays this bad

link $.xhr

  • Scott's proposed API
  • Uses chaining Promise for setting args
  • Downside: requires Promise always
  • will be supported in 1.x branch if possible
    • significantly reduced functionality (no XHR2 or CORS)
  • Promise lib?
  • $.xhr() returns Promise so we MUST have shim in the bundle
  • Insulate via jQuery.Promise = window.Promise || jQuery.PromiseShim

link markelog to look at a super basic thenable we could build using Deferred

  • perhaps build Deferred on thenable?
  • jauborg returns! Work with markelog on Deferred

link Pull Requests

  • Please review and comment

link Tickets

jQuery Core Team Meeting – Aug 11 2014

Attending: DaveMethvin, markelog, gibson042, m_gol, timmywil

link Trac

  • not sure it will ever be fixed…
  • Dave to check with Corey if this will be fixed
  • could we switch to GH issues?
  • volume is low nowadays
  • No serious objections
  • Need to port over open tickets
  • Dave to talk to Scott

link $.xhr

  • discussed w/ Scott at dev leads mtg
  • staying with options object
  • will be supported in 1.x branch if possible
  • not sure if XHR events are reliable there
  • don't want to use polling

link Promise lib?

  • $.xhr() returns Promise
  • User should build with a Promise lib?
  • jQuery.Promise = window.Promise || shim

link jQuery data cleanup: http://bugs.jquery.com/ticket/15205

  • Should go away once we attach data to elements

link Pull Requests

  • Please review and comment

link Tickets

jQuery Core Team Meeting – Aug 04 2014

Attending: DaveMethvin, markelog, gibson042, m_gol

link Trac

  • status?
  • gnarf is coordinating another meeting to move it along

link Attaching data to DOM elements

link $.xhr

link hide and show mess - http://bugs.jquery.com/ticket/15037

  • Following up on last week's discussion: Is this feasible really?
  • Initially CSS-hidden elements need to work with .show()
  • Simple display:block show will break tables without some special case
  • Probably several other breakages
  • In any case let's avoid making it more complicated, but what can we simplify?
  • gibson042 to do a PR for a simplification
  • .hide() always results in display: none; .show() results in display: "" unless there was a pre-existing non-none value, in which case it will use that

link Pull Requests

link Tickets

jQuery Core Team Meeting – Jul 28 2014

Attending: DaveMethvin, gibson042, markelog, timmywil

link $.xhr

link Trac

  • gnarf coordinating work to update our setup

link Object event handlers

link hide and show mess

  • probably not because initially-CSS-hidden stuff wouldn't be shown
  • Eliminates defaultDisplay mess and saving states

link Tickets

jQuery Core Team Meeting – Jul 14 2014

Attending: mikesherov, DaveMethvin, m_gol

link Test fails

link Migrate: button.attr("value", val) failing, jQuery 1.8 or older

  • http://swarm.jquery.org/result/1914335
  • I think the test may need to be removed
  • Behavior is correct for IE<9 and jQuery<1.9
  • Resolution: Move existing test to the 1.9+ branch in the unit tests
    • gibson042 has a pull

link Support matrix

  • iOS 6.1+ since Browserstack doesn't provide older versions
  • Android 2.3, 4.0+ (not just 4.0+)
  • we have a couple of manipulation failures on 2.3 but no one reported them so let’s claim support

link Dave will be on vacation July 17-26

link $.xhr strawman

  • https://gist.github.com/dmethvin/43ffd1c743554e5c50ae
  • Updated last week with feedback from comments
  • Return value of $.xhr?
    • thenable requires user to translate, and also means we always have a dependency on some sort of thenable shim (e.g., $.Deferred)
    • Promise means we need either a shim or native Promise
    • maybe https://github.com/getify/native-promise-only
  • Oleg on a plane right now, will have some thoughts/comments tomorrow
  • dave to ping domenic for input on how to add .xhr to Promise instance
  • dave to ping snover on collab with Dojo
  • mikesherov to ping getify on using native-promise-only for our shim

link Download builder in 1.12/2.2?

  • Owner?

link Trac sucks

  • Nacin volunteered to help, connected him with gnarf
  • Got a second person (Christopher Schramm) interested as well

link Pulls

  • markelog landed several things this weekend

link Tickets