Attending: DaveMethvin, gibson042, arthurvr, timmywil, markelog, m_gol, mikesherov

link jQuery 3.0 beta

• Still to do:
  • https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0+no%3Aassignee
• jquery-release (timmywil tickets)
  • Doesn't like a 3.0.0 build?
  • Current code hasn't been vetted for major-version release
  • May still work but needs to be tested

link Purpose of _evalURL

• If you replace ajax.js with some other stack, it needs to define _evalURL so that manipulation can run scripts in HTML strings.
• (Unless you want to explicitly deny that perhaps?)
• markelog to add comment so we won't forget (again)

link Pull Requests and Issues

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• offsetParent is wrong for 3D transforms
  • https://github.com/jquery/jquery/issues/1765
  • Proposed solution is going to be slower, not sure of real life impact
  • Standard is not yet final
  • Browser should really do this automatically and reflect the correct value
  • bzbarsky says offsetParent is a legacy thing tho
  • Brings up the whole issue of whether to use gBCR everywhere in place of offsetTop/Left
  • Defer this until 4.0, too much potential for breakage and need to explore it
• Data: rwaldron volunteered to work on it
  • https://github.com/jquery/jquery/pull/1428
  • https://github.com/jquery/jquery/pull/1668 ready to land
  • https://github.com/jquery/jquery/pull/1905 Needs a master version and rebase
  • ping rwaldron

Attending: DaveMethvin, gibson042, arthurvr, timmywl, markelog

link jQuery 3.0 beta

• Still to do:
  • https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0+no%3Aassignee
• jquery-release (timmywil tickets)
  • Doesn't like a 3.0.0 build?

link Style of cherry-picked commits

• https://github.com/jquery/jquery/commit/e2ec5da2a7f1b3de1f9dc7e2c01f27cd23714e60#commitcomment-9253725
• Let's do git cherry-pick -x and keep the comments, be sure to cp into compat rather than the other way around

link $.when changes for single-argument case

• https://github.com/jquery/jquery/issues/2018
• Definitely should eliminate the reuse of the incoming Deferred for the return value
• What about when the single arg is an Array? Keep current behavior, too big an API break
• Basically, one arg is Promise.cast(), multiple is Promise.all()
• Need better docs for $.when if an array is passed

link Formatting ticket and issue references

• https://github.com/jquery/jquery/commit/85ffc6d973865a031ded170934e0acfc2e97cb11#commitcomment-9260170
• Dave turned off the Trac commit hook
• Reference older Trac issues with trac-1234
• Is it safe to reference Github issues and PRs with # instead of gh- now?
• No, could get confusing
• Decided: use gh-xxxx and trac-xxxx for consistency and back-compat (in core)
• https://github.com/jquery/contribute.jquery.org/issues/102

link Pull Requests and Issues

• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0
• Data: rwaldron volunteered to work on it
  • https://github.com/jquery/jquery/pull/1428
  • https://github.com/jquery/jquery/pull/1668
  • ping rwaldron

link Build on Windows

• The node-smoke-test won't work on Windows and node 0.10 without a bunch of stuff installed incluing Visual Studio
• Fixed with io.js or node 0.12 but who knows when they arrive
• For now, can work around with grunt dev, ignore npm install error that doesn't affect the working of other things

Attending: DaveMethvin, jaubourg, timmywil, arthurvr, gibson042, markelog, m_gol

link jQuery 3.0 beta

• Still a LOT to do
  • https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0+no%3Aassignee
• Can everyone get their assigned PRs done this week?

link Pull Requests and Issues

• Style of Support comments
  • https://github.com/jquery/contribute.jquery.org/issues/95
  • I'm good with gibson042 proposal, removing the "< N only" since "<= N-1 only" is clearer
  • Let's start using that now, and do a pass to clean up the existing comments
• .unwrap() conditioned by a selector

• https://github.com/jquery/jquery/pull/2003
• Please review

• jQuery.Deferred enhancements

• https://github.com/jquery/jquery/pull/1996
• Ready to land? waiting for jaubourg’s review
• Still need some way to signal unhandled rejections, gibson042 to make a proposal

• jQuery.parseHTML("")

• https://github.com/jquery/jquery/pull/1998
• I like the idea of doing more here but given how much we need to do for 3.0 I'm okay with just this change if nobody has time to take something more ambitious.
• Let's ask Krinkle to update the PR for the more ambitious changes that track what the native method does, see comments in the PR from timmywil and gibson042

• Funny characters in tag names

• https://github.com/jquery/jquery/pull/1988
• Same here as with parseHTML, if someone can take it now we could do more but otherwise let's land this smaller fix. (But note gibson042 comments regarding colons for namespaces.)
• Let's land this now (hyphens), do a second commit for the more general changes (unusual characters, namespaces)

• Inserted scripts run async

• https://github.com/jquery/jquery/issues/1895
• Need to land a change like this for a 3.0 beta so people can see what might break (e.g., templates with embedded script)

• jquery-release tasks (timmywil)

• Can these get done this week? Need at least some of them to ship the beta. (timmy says yes)
• https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+assignee%3Atimmywil+label%3ABuild

Attending: DaveMethvin, gibson042, markelog, arthurvr

link jQuery 3.0 beta

• Still a LOT to do
  • https://github.com/jquery/jquery/issues?q=is%3Aopen+is%3Aissue+milestone%3A3.0.0+no%3Aassignee

link Pull Requests and Issues

• indexOf

• Seems good to have a consistent standard
• Would need to be addressed in the style guide?
• In the meantime, land the two PRs

• https://github.com/jquery/jquery/pull/1980

• land this, we can tweak

• https://github.com/jquery/jquery/pull/1975

• Can we eliminate $.support.cors and use XHR as the default transport if no other transport works?
• Would eliminate a lot of special cases
• Pinged @jaubourg on the possibility

• Skip PATCH tests on BrowserStack

• too many spurious fails from their setups for some reason

Attending: DaveMethvin, gibson042, arthurvr, m_gol, timmywil (12:45)

link Reminder: 3.0 in two weeks!

• Need owners for several tickets
• Need to land exising PRs

link Issues and PRs

• https://github.com/jquery/jquery/issues/1969
  • Is unescaped \f valid in an XHTML document attribute value?
  • Is there some way we can avoid constant XHTML issues? Can we test in XHTML perhaps for an occasional run?
  • m_gol to look at https://github.com/jquery/jquery/issues/1731
• https://github.com/jquery/jquery/issues/1967
  • jQuery.support.cors is in relatively wide use (but not formally documented) for situations like PhoneGap and IE local apps
  • Can this be fixed by selecting XHR as a default transport?
  • Continue discussion on the ticket
• https://github.com/jquery/jquery/issues/1956
  • Get using .html() (avoiding encoding) and set as .text()?

• Asking on the ticket why that can't be done

Attending: DaveMethvin, gibson042, gnarf, m_gol, jaubourg, markelog

link 1.11.2/2.1.3 release

• Done

link Issues and PRs

• Format of // Support: comments
  • https://github.com/jquery/contribute.jquery.org/issues/95
  • Spaces around the numbers and symbols, consistent with JS spacing
• Documenting a ready promise
  • https://github.com/jquery/api.jquery.com/pull/530
  • Currently on jQuery.ready, but that's an internal method
  • m_gol has https://github.com/jquery/jquery/issues/1778
  • Revisit after that ticket is resolved
• Text of a script tag
  • https://github.com/jquery/jquery/issues/1956
• Smoke-testing on Node, not assuming the browser env in source
  • PR: https://github.com/jquery/jquery/pull/1949

link Code coverage

• markelog to create an issue
  • https://github.com/jquery/jquery/issues/1965

Attending: DaveMethvin, m_gol, gibson042, markelog, timmywil

link 1.11.2/2.1.2 release

• All patches landed? They should all be here:

• https://github.com/jquery/jquery/issues?q=milestone%3A1.11.2%2F2.1.2

• Trac tickets listed under a single GH issue

• https://github.com/jquery/jquery/pull/1662 was master only

• Sizzle has been updated in master, compat, 2.1-stable, and 1.11-stable
• Add Ajax URL sanitization?

• https://github.com/jquery/jquery/issues/1875
• No, let's leave until 3.0, there are compat risks

• Release ASAP
• Need blog post draft
• Has jquery-release been updated to not copy -latest? I think so

• (in general, any changes to jquery-release needed?)

link 3.0 release - target mid-January

• Major blockers or unassigned tickets?
• Should we switch to ES6 module format for authoring?

• Can still generate both the monolithic file and AMD from that
• Move AMD modules to dist/AMD
• Breaks the build process, can’t use r.js or var modules
• Can’t load modules when testing
• Decided to not change authoring for 3.0 … wait for 4.0, better tooling and/or browser support before using ES6 for authoring

• QUnit ticket: https://github.com/jquery/qunit/issues/707

link Issues vs Pull Requests

• Let's use issues (only) for changelog
• PRs should have one or more issues, unless they're housekeeping (e.g. typos and such) in which case we don't need an issue
• Need a commit message format change here?
• gibson042 has Component name enforcement

• https://github.com/jquery/jquery/pull/1909

• Support for jquery-release to build changelog

• https://github.com/jquery/jquery-release/issues/1

link Issues and PRs

• Promises/A+ compat

• https://github.com/jquery/jquery/pull/1821
• gibson042 to work on a PR
• maximum backcompat, allow setting context, multiple resolved values, etc. (Promise/A compat for code that draws inside the standard lines)
• Use a plugin to handle the error cases?
• Might be able to use try/finally now that IE7 has been dropped

• Plain Objects

• https://github.com/jquery/jquery/issues/1776
• Do we support animation on Object
• https://github.com/jquery/api.jquery.com/issues/600
• Are the docs/units correct and complete compared to code?
• https://github.com/jquery/jquery/pull/1668
• Should we hide the expando on plain objects? Let's try exposing it and see if anyone depends on it
• Should we add .animate() and .queue() to the list of things supported for plain objects?
• .queue - yes, support on plain objects, little impact
• .animate() - let's look at velocity.js, although it may be as simple as guarding stuff with .nodeType checks

Attending: DaveMethvin, m_gol, gibson042, markelog

link Do we need a 1.12/2.2 release?

• Yes
• Release 12/15?
• Safari selector bug, maybe one or two other low-risk patches
• m_gol suggests starting at https://github.com/jquery/jquery/commit/e488d985cfb10ab8c684bbc6a9b8ff3eae23bf83
• Dave to do blog post on Safari's lack of response and info on this
• m_gol to find jQuery patches and make a branch
• gibson042 to make a Sizzle branch
  • start at 78a8c3a7a83ebd8356ae3e23c7c1970ef6d948d2 or later
  • back out ea1c40428c85de1b08087e9c76c5518ba8d15d4f
  • add PR 297
  • maybe add PR 300

link Schedule for 3.0

• Release target date mid-January
• Firmer dates once we get closer

link Style guide

• Please weigh in
• https://github.com/jquery/contribute.jquery.org/pull/94
• Would like to get JSCS support for whatever we decide

link Issues vs Pull Requests

• Any bug/feature/deprecation should have an issue
• Issues track the functional changes in the release
• Dave to go back and check tags/milestones for pre-3.0 commits

• Think I need to create issues for pre-closed tix in Trac

• (discussion about whether it creates unneeded duplication)
• Could a commit message format change help here?
• Support for jquery-release
  • https://github.com/jquery/jquery-release/issues/1
• Dave to see how other projects deal with this for their changelogs
  • e.g. https://github.com/btford/grunt-conventional-changelog

link Issues

• Remove .context and .selector

• https://github.com/jquery/jquery/issues/1908
• Just have jquery-migrate monkey patch it

• Is the guard around currentStyle.left needed? Probably not

• https://github.com/jquery/jquery/issues/1906
• https://github.com/jquery/jquery/commit/8099cdce800d45109b961e3521fc0080e9a876c6
• Might actually clean up the code nicely

link PRs

• Dropping older browsers on compat: https://github.com/jquery/jquery/pull/1837

• m_gol to update the description at https://github.com/jquery/jquery/issues/1836 to include what’s being dropped

• followup PRs for master (a couple of changes apply there as well)
• https://github.com/jquery/jquery/pull/1901 m_gol to land soon
• Promises/A+ compat: https://github.com/jquery/jquery/pull/1821

• to discuss next week

Attending: DaveMethvin, gibson042, timmywil, m_gol

link Issues and PRs

• https://github.com/jquery/jquery/issues/1874

• Just land a fix, no unit test since it's a resource leak
• Landed in Sizzle

• https://github.com/jquery/jquery/issues/1867

• .detail used in all mouse events, now inclined to just add it

• https://github.com/jquery/jquery/issues/1855

• Just always use gBCR?
• Maybe a bit slower but would provide fractional dimensions for width/height
• Does gBCR also fix offset/position/width/height when elements are transformed? Need to check

link Promises/A+ compat

• https://github.com/jquery/jquery/pull/1821

• make .then() as Promise/A+ compat as it can be
• may be a few minor behavioral things not std
• what about extensions to the Promise/A+ spec? (context, multiple values, progress)
• seems like we need multi values for the most common use case of $.ajax
• keep other Deferred behavior basically unchanged
• no need to introduce breaking changes
• current Deferred functionality won't be enhanced e.g., https://github.com/jquery/jquery/issues/1839

Attending: DaveMethvin, gibson0421, markelog, m_gol

link Issues and PRs

• https://github.com/jquery/jquery/issues/1874
  • save the function wrapper (Sizzle)
• http://bugs.jquery.com/ticket/4320
  • Is this still needed for IE8+?
  • markelog can not repro in IE8 using the test case attached
• https://github.com/jquery/api.jquery.com/issues/597
  • misplaced, asked him to post on our shadowroot ticket
• https://github.com/jquery/jquery/issues/1784
  • not clear how to handle this
  • new APIs?
  • special behavior when context is a shadow root?
  • continue to wait for stds/impl guidance before changing stuff
• https://github.com/jquery/jquery/issues/1875
  • Seems good
• https://github.com/jquery/jquery/pull/1879
  • Nope, too much of a special case and we don't want globals
• Distribution issues - https://github.com/tildeio/rsvp.js/issues/327
  • worth a read
  • Author in ES6, compile to AMD/CommonJS?
  • https://github.com/esnext/es6-module-transpiler
• Plain objects
  • Very few methods work on it http://api.jquery.com/jquery/
  • Let's deprecate in 3.0 and remove later
• https://github.com/jquery/jquery/pull/1847
  • Yep!
• https://github.com/jquery/jquery/pull/1821
  • Promises/A+ compat
  • let's land that as-is and work on gibson042 enhancement