Attending: DaveMethvin, gibson042, gnarf, m_gol, jaubourg, markelog

link 1.11.2/2.1.3 release

• Done

link Issues and PRs

• Format of // Support: comments
  • https://github.com/jquery/contribute.jquery.org/issues/95
  • Spaces around the numbers and symbols, consistent with JS spacing
• Documenting a ready promise
  • https://github.com/jquery/api.jquery.com/pull/530
  • Currently on jQuery.ready, but that's an internal method
  • m_gol has https://github.com/jquery/jquery/issues/1778
  • Revisit after that ticket is resolved
• Text of a script tag
  • https://github.com/jquery/jquery/issues/1956
• Smoke-testing on Node, not assuming the browser env in source
  • PR: https://github.com/jquery/jquery/pull/1949

link Code coverage

• markelog to create an issue
  • https://github.com/jquery/jquery/issues/1965

Attending: DaveMethvin, m_gol, gibson042, markelog, timmywil

link 1.11.2/2.1.2 release

• All patches landed? They should all be here:

• https://github.com/jquery/jquery/issues?q=milestone%3A1.11.2%2F2.1.2

• Trac tickets listed under a single GH issue

• https://github.com/jquery/jquery/pull/1662 was master only

• Sizzle has been updated in master, compat, 2.1-stable, and 1.11-stable
• Add Ajax URL sanitization?

• https://github.com/jquery/jquery/issues/1875
• No, let's leave until 3.0, there are compat risks

• Release ASAP
• Need blog post draft
• Has jquery-release been updated to not copy -latest? I think so

• (in general, any changes to jquery-release needed?)

link 3.0 release - target mid-January

• Major blockers or unassigned tickets?
• Should we switch to ES6 module format for authoring?

• Can still generate both the monolithic file and AMD from that
• Move AMD modules to dist/AMD
• Breaks the build process, can’t use r.js or var modules
• Can’t load modules when testing
• Decided to not change authoring for 3.0 … wait for 4.0, better tooling and/or browser support before using ES6 for authoring

• QUnit ticket: https://github.com/jquery/qunit/issues/707

link Issues vs Pull Requests

• Let's use issues (only) for changelog
• PRs should have one or more issues, unless they're housekeeping (e.g. typos and such) in which case we don't need an issue
• Need a commit message format change here?
• gibson042 has Component name enforcement

• https://github.com/jquery/jquery/pull/1909

• Support for jquery-release to build changelog

• https://github.com/jquery/jquery-release/issues/1

link Issues and PRs

• Promises/A+ compat

• https://github.com/jquery/jquery/pull/1821
• gibson042 to work on a PR
• maximum backcompat, allow setting context, multiple resolved values, etc. (Promise/A compat for code that draws inside the standard lines)
• Use a plugin to handle the error cases?
• Might be able to use try/finally now that IE7 has been dropped

• Plain Objects

• https://github.com/jquery/jquery/issues/1776
• Do we support animation on Object
• https://github.com/jquery/api.jquery.com/issues/600
• Are the docs/units correct and complete compared to code?
• https://github.com/jquery/jquery/pull/1668
• Should we hide the expando on plain objects? Let's try exposing it and see if anyone depends on it
• Should we add .animate() and .queue() to the list of things supported for plain objects?
• .queue - yes, support on plain objects, little impact
• .animate() - let's look at velocity.js, although it may be as simple as guarding stuff with .nodeType checks

Attending: DaveMethvin, m_gol, gibson042, markelog

link Do we need a 1.12/2.2 release?

• Yes
• Release 12/15?
• Safari selector bug, maybe one or two other low-risk patches
• m_gol suggests starting at https://github.com/jquery/jquery/commit/e488d985cfb10ab8c684bbc6a9b8ff3eae23bf83
• Dave to do blog post on Safari's lack of response and info on this
• m_gol to find jQuery patches and make a branch
• gibson042 to make a Sizzle branch
  • start at 78a8c3a7a83ebd8356ae3e23c7c1970ef6d948d2 or later
  • back out ea1c40428c85de1b08087e9c76c5518ba8d15d4f
  • add PR 297
  • maybe add PR 300

link Schedule for 3.0

• Release target date mid-January
• Firmer dates once we get closer

link Style guide

• Please weigh in
• https://github.com/jquery/contribute.jquery.org/pull/94
• Would like to get JSCS support for whatever we decide

link Issues vs Pull Requests

• Any bug/feature/deprecation should have an issue
• Issues track the functional changes in the release
• Dave to go back and check tags/milestones for pre-3.0 commits

• Think I need to create issues for pre-closed tix in Trac

• (discussion about whether it creates unneeded duplication)
• Could a commit message format change help here?
• Support for jquery-release
  • https://github.com/jquery/jquery-release/issues/1
• Dave to see how other projects deal with this for their changelogs
  • e.g. https://github.com/btford/grunt-conventional-changelog

link Issues

• Remove .context and .selector

• https://github.com/jquery/jquery/issues/1908
• Just have jquery-migrate monkey patch it

• Is the guard around currentStyle.left needed? Probably not

• https://github.com/jquery/jquery/issues/1906
• https://github.com/jquery/jquery/commit/8099cdce800d45109b961e3521fc0080e9a876c6
• Might actually clean up the code nicely

link PRs

• Dropping older browsers on compat: https://github.com/jquery/jquery/pull/1837

• m_gol to update the description at https://github.com/jquery/jquery/issues/1836 to include what’s being dropped

• followup PRs for master (a couple of changes apply there as well)
• https://github.com/jquery/jquery/pull/1901 m_gol to land soon
• Promises/A+ compat: https://github.com/jquery/jquery/pull/1821

• to discuss next week

Attending: DaveMethvin, gibson042, timmywil, m_gol

link Issues and PRs

• https://github.com/jquery/jquery/issues/1874

• Just land a fix, no unit test since it's a resource leak
• Landed in Sizzle

• https://github.com/jquery/jquery/issues/1867

• .detail used in all mouse events, now inclined to just add it

• https://github.com/jquery/jquery/issues/1855

• Just always use gBCR?
• Maybe a bit slower but would provide fractional dimensions for width/height
• Does gBCR also fix offset/position/width/height when elements are transformed? Need to check

link Promises/A+ compat

• https://github.com/jquery/jquery/pull/1821

• make .then() as Promise/A+ compat as it can be
• may be a few minor behavioral things not std
• what about extensions to the Promise/A+ spec? (context, multiple values, progress)
• seems like we need multi values for the most common use case of $.ajax
• keep other Deferred behavior basically unchanged
• no need to introduce breaking changes
• current Deferred functionality won't be enhanced e.g., https://github.com/jquery/jquery/issues/1839

Attending: DaveMethvin, gibson0421, markelog, m_gol

link Issues and PRs

• https://github.com/jquery/jquery/issues/1874
  • save the function wrapper (Sizzle)
• http://bugs.jquery.com/ticket/4320
  • Is this still needed for IE8+?
  • markelog can not repro in IE8 using the test case attached
• https://github.com/jquery/api.jquery.com/issues/597
  • misplaced, asked him to post on our shadowroot ticket
• https://github.com/jquery/jquery/issues/1784
  • not clear how to handle this
  • new APIs?
  • special behavior when context is a shadow root?
  • continue to wait for stds/impl guidance before changing stuff
• https://github.com/jquery/jquery/issues/1875
  • Seems good
• https://github.com/jquery/jquery/pull/1879
  • Nope, too much of a special case and we don't want globals
• Distribution issues - https://github.com/tildeio/rsvp.js/issues/327
  • worth a read
  • Author in ES6, compile to AMD/CommonJS?
  • https://github.com/esnext/es6-module-transpiler
• Plain objects
  • Very few methods work on it http://api.jquery.com/jquery/
  • Let's deprecate in 3.0 and remove later
• https://github.com/jquery/jquery/pull/1847
  • Yep!
• https://github.com/jquery/jquery/pull/1821
  • Promises/A+ compat
  • let's land that as-is and work on gibson042 enhancement

Attending: gibson0421, m_gol, timmywil

link Sizzle issues:

• https://github.com/jquery/sizzle/issues/290 - new buggyQSA test

link Issues and PRs

• 3.0 milestone: What can be landed now?
  • Assign 3.0 milestone when accepting for 3.0
• Promises/A+ compat
  • https://github.com/jquery/jquery/pull/1821
• gibson042 proposing a change for chained .done()
• m_gol to look into better integration with tests
• Landing https://github.com/jquery/jquery/pull/1837

link Shadow DOM support

• .offset() https://github.com/jquery/jquery/issues/1784
• Sizzle roots https://github.com/jquery/sizzle/issues/296
• Wait for guidance from standards and impls

Attending: DaveMethvin, markelog, timmywil

link Additional issue tracker things

• wontfix? (done)
• cantfix?
• needs review (team needs to review the issue/PR) (done)
• I don't think we want "fixed" or "notabug", too noisy and not particularly useful to search
• "valid and fixed" issues should be assigned to a milestone, be sure they are when committing code that closes an issue
• Always set a milestone when assigning an issue, and always assign the issue before closing with a fix/patch
• Always create an issue for a PR, so the issues have a complete list of the problems solved

link Branch naming still needs to be done

• rename "1.x-master" to "compat"
• also change name in package.json - “jquery-compat”
• handle 4 remaining PRs to 1.x-master, then remove the branch; PRs:
  • https://github.com/jquery/jquery/pull/1506
  • https://github.com/jquery/jquery/pull/1652
  • https://github.com/jquery/jquery/pull/1664
  • https://github.com/jquery/jquery/pull/1704
• don’t merge anything to 1.x-master from now on
• Both versions need package.json rename to 3.0.0-pre

link Issues and PRs in the 3.0 milestone

• What can be landed now?
• Promises/A+ compat
  • https://github.com/jquery/jquery/pull/1821
• gibson042 proposing a change for chained .done()
• m_gol to look into better integration with tests

link $.xhr -- replaced by $.fetch

• Let's do this as a plugin with its own schedule

link Issues and Pull Requests

• Assign milestones to all issues

Attending: timmywil, DaveMethvin, gibson042, m_gol

link Trac issues migrated

• Do we need to consult Trac anymore? Only for historical reference
• Some recently closed tickets need to be pulled into the changelog on the next release, the list is here: https://github.com/jquery/jquery/issues/1727

link Branch naming

• "compat-only" and "master-only" for issues applying to just one -- done
• rename "1.x-master" to "compat"
• also change name in package.json - “jquery-compat”
• Both versions need package.json rename to 3.0.0-pre
• land PRs before renaming

link Promises/A+ compat

• https://github.com/jquery/jquery/pull/1653
• gibson042 proposing a change for chained .done()

link $.xhr -- replaced by $.fetch

• Should this start as a plugin? Yes

link Publish 3.0 blogpost

• Dave to do this week

link Browser support for 3.0.0

• Drop official support for Opera 12 and Safari 5.1
• Keep IE9 in the master branch
• Support Android 2.x on both (dammit)

link Additional things to reconsider as of 3.0?

• remove deprecated stuff like andSelf
• fractional width/height?

link Testing

• Continue to test Opera (latest, latest-1), but on the weekly job
• We could test Yandex browser there if it's on browserstack
• Let's switch to private browser sets (m_gol)
  • jquery and jquery-periodic
  • jquery-compat and jquery-compat-periodic

link Issues and Pull Requests

• Assign milestones to all issues
• https://github.com/jquery/jquery/issues/1784
• Shadow DOM is a pain
  • Is this something jQuery should try to fix?
  • code size and performance implications could be big
  • dave to get some input from Polymer or web standards groups on whether this is reasonable to do, and if so what devs (and jQuery) should be doing to make this work without horrible perf

link Roadmap wiki page?

• Collect all features/enhancements for feedback

Attending: DaveMethvin, jaubourg, markelog, gibson042, m_gol

link Trac

• Should migrate closed tickets (with milestone 1.12 or 2.2. or 1.12/2.2) forward to simplify the changelog - there are 16 of them
  • http://bugs.jquery.com/query?status=closed&milestone=1.12&milestone=2.2&milestone=1.12%2F2.2&group=component&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=component&report=3&order=priority
• open tickets should be migrated as well :)
• dmethvin will migrate when trac feels good enough
• Re-set 1.12.0/2/22.0 milestone to 3.0.0?
• Trac still being worked on for archival use, slow progress

link Branch naming

• Have a "compat-only" and "master-only" for issues applying to just one
• rename "1.x-master" to "compat"
• land PRs before renaming

link Promises/A+ compat

• https://github.com/jquery/jquery/pull/1653
• gibson042 proposing a change for chained .done(), to be done this week
• m_gol to look into better integration with tests

link $.xhr

• markelog examples: https://gist.github.com/markelog/42d43a489afb7201ddd6
• markelog to create an implementation, working on it this week?

link version 3.0

• dmethvin making blog post, to be done this week for review

link Testing

• Continue to test Opera, but on the weekly job
• We could test Yandex browser there if it's on browserstack
• Let's switch to private browser sets (m_gol)
  • jquery and jquery-weekly
  • jquery-compat and jquery-compat-weekly

Attending: DaveMethvin, markelog, m_gol

link Trac

• Switched to GH Issues
• m_gol to find/change incorrect references to Trac
• Still need migration to Trac 1.0 for security/perf reasons
• dmethvin to monitor progress
• New registrations turned off
• Most accounts have been removed (most were spam)
• Only team/trusted logins left
• If you can log in, you can still create or edit tickets
• should migrate closed tickets (with milestone 1.12 or 2.2. or 1.12/2.2) forward to simplify the changelog - there are 16 of them
  • http://bugs.jquery.com/query?status=closed&milestone=1.12&milestone=2.2&milestone=1.12%2F2.2&group=component&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=component&report=3&order=priority
• open tickets should be migrated as well :)

link Promise Error telemetry

• mikesherov will talk to Domenic

link Promises/A+ compat

• https://github.com/jquery/jquery/pull/1653
• the PR is outdated, look at the standard-then-tests-fixed branch:
  • https://github.com/jquery/jquery/tree/standard-then-tests-fixed
• needs review, now converted to std Promise rather than Q
• https://github.com/jquery/jquery/commit/d0e5c0447775239edc7819960b7c61b4b71d402f#commitcomment-7914547
• gibson042 proposing a change for .then().done() not failing, to be done this week
• m_gol to look into better integration with tests

link $.xhr

• markelog examples: https://gist.github.com/markelog/42d43a489afb7201ddd6
• strange uses of ajax setup:
  • https://github.com/search?q=ajaxsetup&ref=reposearch&type=Code&utf8=%E2%9C%93
• markelog to create an implementation

link versioning proposals (see last week for deeper discussion)

• version- and API-synchronized

• jquery 1.11.1 → jquery-compat 3.0.0
• jquery 2.1.1 → jquery 3.0.0

• methods & properties existing in both packages have identical signatures & structure for a given version
• public API MUST NOT exist only in jquery-compat distribution
• public API MAY exist only in jquery distribution
• files on cdn are jquery-3.0.0.js and jquery-compat-3.0.0.js etc.
• RESOLVED: we use the same version number for both branches
• dmethvin to make a blog post